Ichi

Off-Chain (Private)

Audited on 2021/06/09

No active critical issues

Summary

During the audit, 29 issues were identified ranging from High to Undetermined severity. We recommend addressing all issues before using the code in production. The documentation provided was of high quality which facilitated the audit. Although the tests are of high coverage, we recommend adding more tests to cover the issues presented in the findings. **Update:** Our report has been updated based on commit [11c210e](https://github.com/ichifarm/ichi-oneToken/commit/11c210ee87509128f35ed6636f0cb3d77733e74b). All issues have been either resolved or acknowledged.

Project

ICHI

Multi-Chain

Issues (29)

	Low	Medium	High	Critical	Total
Not fixed	7	1	-	-	8
Fixed	14	3	4	-	21
Total	21	4	4	0	29

Contracts (69)

#	File Name
21	contracts/strategy/StrategyCommon.sol
22	contracts/version/v1/OneTokenV1Base.sol
23	contracts/testToken/Token6.sol
24	contracts/_openzeppelin/access/Ownable.sol
25	contracts/Migrations.sol
26	contracts/controller/null controller/NullController.sol
27	contracts/oracle/OracleCommon.sol
28	contracts/_uniswap/v2-core/contracts/libraries/UniSafeMath.sol
29	contracts/_uniswap/lib/contracts/libraries/BitMath.sol
30	contracts/oracle/composite/ICHICompositeOracle.sol

#	File Name
21	contracts/strategy/StrategyCommon.sol
22	contracts/version/v1/OneTokenV1Base.sol
23	contracts/testToken/Token6.sol
24	contracts/_openzeppelin/access/Ownable.sol
25	contracts/Migrations.sol
26	contracts/controller/null controller/NullController.sol
27	contracts/oracle/OracleCommon.sol
28	contracts/_uniswap/v2-core/contracts/libraries/UniSafeMath.sol
29	contracts/_uniswap/lib/contracts/libraries/BitMath.sol
30	contracts/oracle/composite/ICHICompositeOracle.sol

Ichi

Summary

Issues (29)

Privileged Roles and Ownershipnot_fixed/medium

`maxOrderVolume` is always `INFINITE`not_fixed/low

`setStrategyAllowance` misses funds that are currently deployednot_fixed/low

Clone-and-Ownnot_fixed/low

Stub volatility valuesnot_fixed/low

Contracts (69)