Icraft

Contract has a floating solidity pragma version. This is present also in inherited contracts. Locking the pragma helps to ensure that the contract does not accidentally get deployed using, for example, an outdated compiler version that might introduce bugs that affect the contract system negatively. The recent solidity pragma version also possesses its own unique bugs.

some functions in the contract require providing an array of addresses to perform its functionality, however, it fails to check the inclusivity of a null address among the parameters. While it is certain that when the mintNFT function is called, it will revert when null address is passed into it due to the present of the null address check prevent in the safeMint internal function called from ERC721 inherited from Openzeppelin, there is a need to add the check to the updateRoyalties function to avoid setting a null address as a receiver of the null address.

Contracts are integrated with the standard Openzeppelin ownable contract, however, when the owner mistakenly transfers ownership to an incorrect address, ownership is completely removed from the original owner and cannot be reverted. The transferOwnership() function in the ownable contract allows the current owner to transfer his privileges to another address. However, inside transferOwnership() , the newOwner is directly stored in the storage, after validating the newOwner is a non-zero address, which may not be enough.