Vaporware
Summary
Overall, the code is well written and easy to follow, not to mention having a low degree of centralization, which we like to see. However, there are several concerns that we would like to raise with the Vaporware team. Out of all issues, the most concerning are the high level issues: VAP-1, VAP-2, VAP-3. We believe that the current implementation makes use of a reward disbursement system that doesn't work as intended and needs to be reworked. Additionally, the test coverage that is currently available highlights the need to cover more possible branches within the code to reduce the risk of encountering any unexpected behaviors. Finally, we would also like to highlight that `EIP-6551` is still in draft and has not fully been accepted yet, which may lead to integration issues down the line. **Update:** The Vaporware team has successfully addressed the issues with the rewards distribution system and acknowledged that `EIP-6551` is still in draft. However, while the test coverage has increased (see the update on VAP-3 for more details), it is still lower than what we would like to see. We recommended improving test coverage prior to going live.
Issues (19)
Low | Medium | High | Critical | Total | |
|---|---|---|---|---|---|
Not fixed | 7 | 1 | 1 | - | 9 |
Fixed | 8 | - | 2 | - | 10 |
| Total | 15 | 1 | 3 | 0 | 19 |