Definer

Off-Chain (Private)

Audited on 2021/01/31

1 active critical issue

Summary

Executive Summary This report presents the results of our engagement with DeFiner to review DeFiner’s SavingAccount protocol. The review was conducted over two weeks, from Feb 8, 2021 to Feb 19, 2021 by Shayan Eskandari and Alex Wade. A total of 15 person-days were spent. Scope Our review focused on the commit hash 880e9aaa883b4d9b68ed9ff3c47e9347345526cc. The list of files in scope can be found in the Appendix. Security Specification This section describes, from a security perspective, the expected behavior of the system under review.

Project

DeFiner.org

Multi-Chain

Issues (9)

	Low	Medium	High	Critical	Total
Not fixed	1	5	2	1	9
Fixed	-	-	-	-	0
Total	1	5	2	1	9

Contracts (13)

#	File Name
11	contracts/config/GlobalConfig.sol
12	contracts/Bank.sol
13	contracts/oracle/ChainLinkAggregator.sol

#	File Name
11	contracts/config/GlobalConfig.sol
12	contracts/Bank.sol
13	contracts/oracle/ChainLinkAggregator.sol

Definer

Summary

Issues (9)

Users can withdraw their funds immediately when they are over-leveragednot_fixed/critical

Stale Oracle prices might affect the ratesnot_fixed/high

Users can borrow funds, deposit them, then borrow morenot_fixed/high

Accounts contains expensive loopingnot_fixed/medium

Commented out code in the codebasenot_fixed/medium

Contracts (13)