Fodl
Summary
After reviewing the codebase, we have found a number of low-severity and informational issues. Overall, the code appears to be well-written and properly tested. It is lacking, however, good documentation. We recommend improving the documentation and addressing the indicated issues. **Update 1:** the team addressed the issues we indicated as of commit `c56a53e`. **Update 2:** we have performed a diff audit based on commit `6aad783`. Although we have not found serious issues, we would like to reiterate the following: 1) the lack of documentation/specification makes it difficult to check whether the code actually works as expected, and 2) there are some unchecked return values as indicated by Slither. Furthermore, the new functionality contains a large number of code clones which could be easily eliminated. **Update 3:** team's response to QSP-4 has been added.
Issues (11)
Low | Medium | High | Critical | Total | |
|---|---|---|---|---|---|
Not fixed | 6 | - | - | - | 6 |
Fixed | 5 | - | - | - | 5 |
| Total | 11 | 0 | 0 | 0 | 11 |