Illuvium (Part 4 - Staking V2)
Summary
Quantstamp has reviewed the V2 staking mechanism for Illuvium. Several issues have been found of various severity levels, and all have been addressed. Although the project has high test coverage, much of the code involves math which is not particularly well justified. Code documentation exists, but is descriptive rather than explanatory. In other cases, issues are likely by design and more-or-less unavoidable (such as the privileged roles). Finally, we note there are a couple of best practices which could be followed, and the code would benefit from additional helper functions to reduce code repetition. Finally, the code has evolved over the evolution of the audit, but new code reintroduced old problems; we strongly recommend keeping this report in mind as the code continues to evolve.
