Native v2 (Security Review)

The variables `totalUnderlying` and `totalShares` are both used as denominators in critical functions. While the denominators are checked to prevent division by zero in most places, this check is missing in some places. Specifically, the functions `deposit()` and `getSharesByUnderlying()` do not check against `totalUnderlying == 0`, while the function `redeem()` does not check against `totalShares == 0`.

The `CreditVault.sol` contract enables trading in a market through the `supportMarket()` function. This function adds the market corresponding to a `LPToken.sol` contract instance. However, no checks or initialization takes place within this function to ensure that the market is indeed ready to be traded. The exact impact of this issue is unclear because documentation or specification for this procedure is unavailable. The conditions and invariant that must hold for the market to be tradable is also unclear and not documented. Given the lack of information we have marked it as an Undetermined, as there is still the possibility of system failure due to a transaction being called to a market that has not been properly initialized.

Supporting tokens with specific features such as fees, rebasing, pausable, upgradeable, blacklistable, or hooks on transfers could negatively impact the main flows of the system if no specific mitigation measure is enforced to limit the consequences.