Bancor V2 AMM Security Audit

Off-Chain (Private)

Audited on 2020/05/31

No active critical issues

Summary

Executive Summary This report presents the results of our engagement with Bancor to review version 2 of the Bancor Liquidity pool. The initial review was conducted over the course of two weeks, from July 15th to July 26th, 2020 by Bernhard Mueller and Sergii Kravchenko. A total of 15 person-days were spent. During the first week, the auditors familiarized themselves with the existing Bancor codebase as well as the novel concepts introduced with version 2 of the liquidity pool.

Project

Bancor

Ethereum

Issues (6)

	Low	Medium	High	Critical	Total
Not fixed	-	1	-	-	1
Fixed	1	-	3	1	5
Total	1	1	3	1	6

Contracts (7)

#	File Name
1	solidity/contracts/utility/TokenHandler.sol
2	solidity/contracts/utility/PriceOracle.sol
3	solidity/contracts/utility/ReentrancyGuard.sol
4	solidity/contracts/utility/TokenHolder.sol
5	solidity/contracts/utility/Owned.sol
6	solidity/contracts/converter/BancorFormula.sol
7	solidity/contracts/converter/ConverterBase.sol

#	File Name
1	solidity/contracts/utility/TokenHandler.sol
2	solidity/contracts/utility/PriceOracle.sol
3	solidity/contracts/utility/ReentrancyGuard.sol
4	solidity/contracts/utility/TokenHolder.sol
5	solidity/contracts/utility/Owned.sol
6	solidity/contracts/converter/BancorFormula.sol
7	solidity/contracts/converter/ConverterBase.sol

Bancor V2 AMM Security Audit

Summary

Issues (6)

Use of external calls with a fixed amount of gasnot_fixed/medium

Contracts (7)