Secured Finance - Diff Audit
Summary
This audit report presents a differential analysis, underscoring the modifications between the former audit at commit `#92f4e85` and the current state at commit `#f1c62764`. Key updates include the integration of ZCTokens, enabling users to tokenize their Zero Coupon Bonds (lending positions) and facilitate their transfer beyond the Secured Finance protocol. The diff audit resulted in 14 findings: 0 high, 2 medium, 7 low, and 5 informational. During the audit, the client identified and highlighted several concerns, which are detailed in this report. These concerns are specifically related to SF-1, SF-2, SF-5, SF-6, and SF-10. Regarding testing, a significant number of tests fail due to an issue with an iterative test that fails a quarter of the way through. We highly recommend fixing the testing suite by ensuring that all tests pass. The project implements code coverage metrics. It shows 87.19% of branch coverage. We also recommend improving the branch coverage to a minimum of 95% and adding new tests to cover the proposed fixes. **Fix Review:** The Secured Finance team has either fixed or acknowledged all issues found within the report, and provided a new commit containing fixes for the issues found. The test suite has been improved to have 2044 passing tests, no failures, and slightly improved coverage.
Issues (14)
Low | Medium | High | Critical | Total | |
|---|---|---|---|---|---|
Not fixed | 5 | - | - | - | 5 |
Fixed | 7 | 2 | - | - | 9 |
| Total | 12 | 2 | 0 | 0 | 14 |