Pods Finance Ethereum Volatility Vault Audit #1

Off-Chain (Private)

Audited on 2022/12/15

No active critical issues

Summary

(4 resolved, 1 partially resolved) Low Severity Issues 9 (5 resolved, 2 partially resolved) Notes & Additional Information 13 (8 resolved) Scope We audited the pods-finance/yield-contracts repository at the 9389ab46e9ecdd1ea1fd7228c9d9c6821c00f057 commit. In scope were the following contracts: contracts/... Three critical and three high-severity issues are found among various lower-severity issues. The system documentation and diagrams provided by the Pods Finance team made it easier for the auditors to assess and comprehend the code. Throughout the audit, the team has been responsive and active...

Project

Ethereum.org

Multi-Chain

Issues (23)

	Low	Medium	High	Critical	Total
Not fixed	2	3	-	-	5
Fixed	7	5	3	3	18
Total	9	8	3	3	23

Contracts (13)

#	File Name
1	contracts/interfaces/IERC4626.sol
2	contracts/libs/DepositQueueLib.sol
3	contracts/libs/AuxMath.sol
4	contracts/interfaces/ICurvePool.sol
5	contracts/interfaces/IVault.sol
6	contracts/vaults/BaseVault.sol
7	contracts/proxy/Migration.sol
8	contracts/proxy/ETHAdapter.sol
9	contracts/libs/CastUint.sol
10	contracts/configuration/ConfigurationManager.sol

#	File Name
1	contracts/interfaces/IERC4626.sol
2	contracts/libs/DepositQueueLib.sol
3	contracts/libs/AuxMath.sol
4	contracts/interfaces/ICurvePool.sol
5	contracts/interfaces/IVault.sol
6	contracts/vaults/BaseVault.sol
7	contracts/proxy/Migration.sol
8	contracts/proxy/ETHAdapter.sol
9	contracts/libs/CastUint.sol
10	contracts/configuration/ConfigurationManager.sol

Pods Finance Ethereum Volatility Vault Audit #1

Summary

Issues (23)

Funds held in ETHAdapter can be drained by anyonenot_fixed/medium

Non-existent permit functionnot_fixed/medium

Refund can be over-credited in a negative yield eventnot_fixed/medium

Missing docstringsnot_fixed/low

Unnecessarily complex codenot_fixed/low

Contracts (13)