CapsuleNFT

Off-Chain (Private)

Audited on 2022/05/26

No active critical issues

Summary

We raised a total of 16 issues, with two of them rated as high severity ones. During the reaudit phase, the CapsuleNFT has demonstrated that 3 issues were false-positives. In general, the issues are related to validation of input/output parameters, and some best practices (such as emitting events and implementation of interfaces). The code is easy to follow, which shows a good programming style. The `blacklist` feature is still not used by the application. The CapsuleNFT provided fast response in addressing the issues (or acknowledging them, when the issue has no practical solution or it is the intended behavior of the application). In terms of tests, we recommend code coverage above 90%.

Project

CapsuleNFT

Ethereum

Issues (16)

	Low	Medium	High	Critical	Total
Not fixed	5	-	2	-	7
Fixed	8	-	1	-	9
Total	13	0	3	0	16

Contracts (35)

#	File Name
31	contracts/openzeppelin/contracts/token/ERC721/IERC721Receiver.sol
32	contracts/Errors.sol
33	contracts/CapsuleFactory.sol
34	contracts/openzeppelin/contracts/token/ERC721/IERC721.sol
35	contracts/CapsuleMinter.sol

#	File Name
31	contracts/openzeppelin/contracts/token/ERC721/IERC721Receiver.sol
32	contracts/Errors.sol
33	contracts/CapsuleFactory.sol
34	contracts/openzeppelin/contracts/token/ERC721/IERC721.sol
35	contracts/CapsuleMinter.sol

CapsuleNFT

Summary

Issues (16)

`CapsuleMinter` does not check whether pre- and post-deposit ERC20 amounts are the samenot_fixed/high

Anyone can call `initialize`not_fixed/high

Clone-and-Ownnot_fixed/low

Possibility of minting more than one NFT having the same `URI`not_fixed/low

Privileged roles and ownershipnot_fixed/low

Contracts (35)