Nomad

Off-Chain (Private)

Audited on 2022/06/09

Rekt reported

Summary

**Initial audit**: <br> Through reviewing the code, we found **40 potential issues** of various levels of severity:`1` high-severity, `6` medium-severity, `18` low-severity, `9` informational-security and `6` undermined issues. We recommend addressing all the issues before deploying the code. </br> **After the re-audit**: </br> The Nomad team has fixed the majority of the issues and the contracts are ready to be deployed, we also found a new issue the QSP-40.

Project

Nomad

Ethereum

Issues (40)

	Low	Medium	High	Critical	Total
Not fixed	28	2	-	-	30
Fixed	5	4	1	-	10
Total	33	6	1	0	40

Contracts (66)

#	File Name
41	Nomad/monrepo/packages/contracts-core/contracts/XAppConnectionManager.sol
42	Nomad/monrepo/packages/contracts-bridge/contracts/test/TestBridgeRouter.sol
43	Nomad/monrepo/packages/contracts-core/contracts/test/TestCommon.sol
44	Nomad/monrepo/packages/contracts-core/contracts/test/TestMerkle.sol
45	Nomad/monrepo/packages/contracts-bridge/contracts/Encoding.sol
46	Nomad/monrepo/packages/contracts-core/contracts/test/TestRecipient.sol
47	Nomad/monrepo/packages/contracts-bridge/contracts/BridgeMessage.sol
48	Nomad/monrepo/packages/contracts-router/contracts/XAppConnectionClient.sol
49	Nomad/monrepo/packages/contracts-core/contracts/UpdaterManager.sol
50	Nomad/monrepo/packages/local-environment/tests/utils/token/contract/IERC20.sol

#	File Name
41	Nomad/monrepo/packages/contracts-core/contracts/XAppConnectionManager.sol
42	Nomad/monrepo/packages/contracts-bridge/contracts/test/TestBridgeRouter.sol
43	Nomad/monrepo/packages/contracts-core/contracts/test/TestCommon.sol
44	Nomad/monrepo/packages/contracts-core/contracts/test/TestMerkle.sol
45	Nomad/monrepo/packages/contracts-bridge/contracts/Encoding.sol
46	Nomad/monrepo/packages/contracts-core/contracts/test/TestRecipient.sol
47	Nomad/monrepo/packages/contracts-bridge/contracts/BridgeMessage.sol
48	Nomad/monrepo/packages/contracts-router/contracts/XAppConnectionClient.sol
49	Nomad/monrepo/packages/contracts-core/contracts/UpdaterManager.sol
50	Nomad/monrepo/packages/local-environment/tests/utils/token/contract/IERC20.sol

Nomad

Summary

Issues (40)

Long Queues Can Lead To Denial Of Servicenot_fixed/medium

Watcher Availability Concernnot_fixed/medium

`_dust` Method Can Be Abusednot_fixed/low

Incompatibility With Deflationary Tokensnot_fixed/low

Replay Attack In The `improperUpdate` not_fixed/low

Contracts (66)