Stakewise - v3 Vaults / EthFoxVault

Off-Chain (Private)

Audited on 2024/02/29

No active critical issues

Summary

Executive Summary This report presents the results of our engagement with StakeWise and Consensys to review v3 Vaults/EthFoxVault implementation for Consensys. The review was conducted over three weeks, from January 29, 2024, to March 1, 2024. A total of 30 person-days were spent. Stakewise V3 is a liquid staking protocol set to be utilized by Consensys as the underlying system for Metamask Staking. This modular system comprises a collection of customizable modules that define the behavior of a staking vault.

Project

Stakewise Landing

Ethereum

Issues (15)

	Low	Medium	High	Critical	Total
Not fixed	9	4	-	-	13
Fixed	1	1	-	-	2
Total	10	5	0	0	15

Contracts (55)

#	File Name
31	v3-core/contracts/interfaces/IMulticall.sol
32	v3-core/contracts/interfaces/IVaultBlocklist.sol
33	v3-core/contracts/interfaces/IVaultFee.sol
34	v3-core/contracts/vaults/modules/VaultWhitelist.sol
35	v3-core/contracts/vaults/modules/VaultToken.sol
36	v3-core/contracts/interfaces/IVaultWhitelist.sol
37	v3-core/contracts/interfaces/IRewardSplitter.sol
38	v3-core/contracts/vaults/ethereum/custom/EthFoxVault.sol
39	v3-core/contracts/interfaces/IKeeperValidators.sol
40	v3-core/contracts/vaults/modules/VaultVersion.sol

#	File Name
31	v3-core/contracts/interfaces/IMulticall.sol
32	v3-core/contracts/interfaces/IVaultBlocklist.sol
33	v3-core/contracts/interfaces/IVaultFee.sol
34	v3-core/contracts/vaults/modules/VaultWhitelist.sol
35	v3-core/contracts/vaults/modules/VaultToken.sol
36	v3-core/contracts/interfaces/IVaultWhitelist.sol
37	v3-core/contracts/interfaces/IRewardSplitter.sol
38	v3-core/contracts/vaults/ethereum/custom/EthFoxVault.sol
39	v3-core/contracts/interfaces/IKeeperValidators.sol
40	v3-core/contracts/vaults/modules/VaultVersion.sol

Stakewise - v3 Vaults / EthFoxVault

Summary

Issues (15)

Inconsistent Interface Between Similar Functionality: Whitelist / Blocklistnot_fixed/medium

KeeperRewards.canUpdateRewards() and VaultMev._harvestAssets() Can Theoretically Overflownot_fixed/medium

User Can Prevent Blocklist Manager From Ejecting Them by Reverting on ETH Transfernot_fixed/medium

VaultsRegistry Allows Owner to Bypass VaultFactorynot_fixed/medium

_processTotalAssetsDelta() Should Return Early on totalAssetsDelta == 0not_fixed/low

Contracts (55)