LandShare

The constructors of all four audited contracts (CrossChainVault, CrossChainReceiver, CrossChainSender, and CCIPTokenSender) do not currently include checks to prevent zero addresses from being set. If any of these addresses are inadvertently set to the zero address, it could lead to the contracts being in an incorrect or unusable state, potentially causing operational issues and security vulnerabilities.

The getFailedMessagesIds function retrieves the IDs of failed messages by iterating over the entire s_failedMessages map. If the number of failed messages is large, this loop could consume excessive gas and potentially cause the transaction to revert due to reaching the gas limit.

The contracts rely on strict access control mechanisms, where each contract has specific counterparties it should accept transactions from:• CrossChainVault should accept transactions only from CrossChainReceiver. • CCIPTokenSender should accept transactions only from CrossChainVault. • CrossChainReceiver should accept transactions only from IRouterClient. • CrossChainSender is available for all token holders • CCIPTokenSender should accept transactions only from trusted addresses However, the allowlists are managed via separate instructions from the contract owner. If the allowlist configurations are set incorrectly, the contracts could end up in an improper state, potentially leading to security vulnerabilities or operational failures. It is crucial to document the access control processes thoroughly and ensure that the allowlist configuration is managed carefully to prevent such issues.