Bancor Compounding Rewards Audit

Off-Chain (Private)

Audited on 2022/09/06

No active critical issues

Summary

Bancor Compounding Rewards Audit August 4, 2022 This security assessment was prepared by OpenZeppelin, protecting the open economy. Table of Contents Summary The client asked us to review the smart contracts related to the auto-compounding rewards module, including the mathematical dependencies... Severity Issues 5 (1 partially resolved) Notes & Additional Information 3 (1 resolved, 1 partially resolved) Scope We audited commit b2224595afab14827ee065cb65a1444d61689fb3 of the bancorprotocol/contracts-v3 repository. In scope were the following contracts: contracts...

Project

Bancor

Ethereum

Issues (9)

	Low	Medium	High	Critical	Total
Not fixed	5	3	-	-	8
Fixed	-	-	1	-	1
Total	5	3	1	0	9

Contracts (9)

#	File Name
1	contracts/pools/PoolCollection.sol
2	contracts/utility/FractionLibrary.sol
3	contracts/utility/Fraction.sol
4	contracts/rewards/RewardsMath.sol
5	contracts/rewards/AutoCompoundingRewards.sol
6	contracts/utility/MathEx.sol
7	contracts/utility/Constants.sol
8	contracts/rewards/interfaces/IAutoCompoundingRewards.sol
9	contracts/pools/BNTPool.sol

#	File Name
1	contracts/pools/PoolCollection.sol
2	contracts/utility/FractionLibrary.sol
3	contracts/utility/Fraction.sol
4	contracts/rewards/RewardsMath.sol
5	contracts/rewards/AutoCompoundingRewards.sol
6	contracts/utility/MathEx.sol
7	contracts/utility/Constants.sol
8	contracts/rewards/interfaces/IAutoCompoundingRewards.sol
9	contracts/pools/BNTPool.sol

Bancor Compounding Rewards Audit

Summary

Issues (9)

calcExpDecayRewards is at risk of overflow reversionsnot_fixed/medium

Lack of validationnot_fixed/medium

weightedAverage calculation might overflownot_fixed/medium

Duplicated codenot_fixed/low

enableProgram is overloadednot_fixed/low

Contracts (9)