Notional Fin Security Smart Contract Audit

Summary

Executive Summary This report presents the results of our engagement with Notional Finance to review Strategy Vaults. The review was conducted over 5 weeks, from 07/04/2022 to 08/05/2022 by George Kobakhidze, Chingiz Mardanov and Sergii Kravchenko. A total of 8 person-weeks were spent. Scope Our review focused on the commit hash 6212a09576ff18eea8b3291667617b724a8e9b1b for contracts-v2 and 82eeb5b10285f98553d7b55a94c407ff7e09e818 for strategy-vaults. The list of files in scope can be found in the Appendix.

Project

Notional Finance

Multi-Chain

No active critical issues

Last audited on 2022/06/30

Auditor

59 audits on Trustblock

Multi-Tags

Issues (11)

	Low	Medium	High	Critical	Total
Not fixed	9	2	-	-	11
Fixed	-	-	-	-	0
Total	9	2	0	0	11

Contracts (7)

#	File Name
1	contracts-v2/contracts/internal/vaults/VaultAccount.sol
2	contracts-v2/contracts/external/actions/VaultAccountAction.sol
3	contracts-v2/contracts/internal/vaults/VaultConfiguration.sol
4	strategy-vaults/contracts/vaults/CrossCurrencyfCashVault.sol
5	contracts-v2/contracts/internal/vaults/VaultState.sol
6	contracts-v2/contracts/external/actions/VaultAction.sol
7	strategy-vaults/contracts/vaults/BaseStrategyVault.sol

Notional Finance

Summary

Issues (11)

Handle division by 0not_fixed/medium

VaultConfig.setVaultConfig doesn’t check all critical argumentsnot_fixed/medium

An account roll may be impossible if the vault is already at the maximum borrow capacity.not_fixed/low

Cross currency strategy should not have same lend and borrow currenciesnot_fixed/low

Increasing a leveraged position in a vault with secondary borrow currency will revertnot_fixed/low

Contracts (7)