Notional Governance Contracts v2 Audit

Off-Chain (Private)

Audited on 2021/11/05

No active critical issues

Summary

The Notional Finance team asked us to review and audit the governance smart contracts of their v2 Protocol. We looked at the codebase and now publish our results. Scope We audited commit c37c89c9729b830637558a09b6f22fc6a735da64 of the notional-finance/contracts-v2 repository. In scope were... where relevant. To ensure security, we recommend having the updated code audited once it is ready for review. All other project’s files and directories (including tests), along with external dependencies and projects, game theory, and incentive design, were also excluded from the scope of this audit...

Project

Notional Finance

Multi-Chain

Issues (22)

	Low	Medium	High	Critical	Total
Not fixed	4	4	-	-	8
Fixed	8	5	1	-	14
Total	12	9	1	0	22

Contracts (5)

#	File Name
1	contracts/external/governance/Reservoir.sol
2	interfaces/notional/NotionalProxy.sol
3	contracts/external/governance/NoteERC20.sol
4	contracts/global/Constants.sol
5	contracts/external/governance/GovernorAlpha.sol

#	File Name
1	contracts/external/governance/Reservoir.sol
2	interfaces/notional/NotionalProxy.sol
3	contracts/external/governance/NoteERC20.sol
4	contracts/global/Constants.sol
5	contracts/external/governance/GovernorAlpha.sol

Notional Governance Contracts v2 Audit

Summary

Issues (22)

[M01] Approval process can be front-runnot_fixed/medium

[M05] Test coverage script fails to deliver the reportnot_fixed/medium

[M07] Mistakenly deposited tokens in Reservoir would get stucknot_fixed/medium

[M08] Untested custom SafeMath library in usenot_fixed/medium

[L03] Implicit castingnot_fixed/low

Contracts (5)