Executive Summary This report presents the results of our engagement with 1inch to review AggregationRouter V5. The review was conducted over two weeks, from August 15 2022 to September 16 2022 by Chingiz Mardanov and George Kobakhidze. A total of 40 person-days were spent. Scope Our review focused on the following repositories and commit hashes: https://github.com/1inch/1inch-contract @ 3461c75d00481d111f0323d7e1cb6e56b0dc7ec0, https://github.com/1inch/limit-order-protocol @ 403be0f583b863b3b13373c23e8f2652f5ef720d, https://github.com/1inch/solidity-utils @ 32b04c767db00d4ddc2428534fd6e90abbacb12e. The list of files in scope can be found in the Appendix.
Low | Medium | High | Critical | Total | |
---|---|---|---|---|---|
Not fixed | 5 | 4 | 2 | - | 11 |
Fixed | - | - | - | - | 0 |
Total | 5 | 4 | 2 | 0 | 11 |
# | File Name |
---|---|
1 | 1inch-contract/contracts/helpers/Errors.sol |
2 | limit-order-protocol/contracts/interfaces/IOrderMixin.sol |
3 | 1inch-contract/contracts/interfaces/IClipperExchangeInterface.sol |
4 | 1inch-contract/contracts/routers/ClipperRouter.sol |
5 | solidity-utils/contracts/interfaces/IWETH.sol |
6 | limit-order-protocol/contracts/interfaces/NotificationReceiver.sol |
7 | limit-order-protocol/contracts/helpers/AmountCalculator.sol |
8 | 1inch-contract/contracts/routers/UnoswapRouter.sol |
9 | limit-order-protocol/contracts/libraries/Errors.sol |
10 | limit-order-protocol/contracts/libraries/ArgumentsDecoder.sol |