Zynk Labs V1

QuillAudits21 Feb 2025Files named in the report

Audit · firm’s term: audit report

QuillAudits reviewed Zynk Labs-Solana (Zynk Labs V1) on 21 Feb 2025: 6 findings, 0 critical; none marked fixed.

No open critical findings

Open the report Open Zynk Labs-Solana’s security record

Report hosted on quillaudits.com.

Trustblock does not review code.

Findings6

Statuses are the security firm’s own, from its report.

Severity	Open	Acknowledged	Fixed
Critical	0	0	0
High	0	0	0
Medium	1	0	0
Low	5	0	0

MediumUse abi.encode instead of abi.encodePackedOpen

The function checkSum currently uses abi.encodePacked to hash the partnerId. While abi.encodePacked creates a compact encoding, it can lead to potential collisions when concatenating multiple dynamic types. Using abi.encode ensures a more structured encoding, reducing ambiguity and preventing unintended hash collisions.

LowCentralization RiskOpen

Even though all the actors in the protocols are trusted, it is still important to remember that the contract has many points of failure in case of compromised or trusted actors like admin, partners, manager etc.

LowChange confusing function nameOpen

The function revokeReplenish() marks an order as active instead of revoking it, which is counterintuitive and can lead to misunderstandings during contract interactions.

LowHardcoded chainId might be problematicOpen

The contract initializes chainId using block.chainid in the constructor, but it does not account for potential chain migrations or forks where chainId may change. This can cause issues with cross-chain validation and future compatibility.

LowUse ownable2Step instead of OwnableOpen

The contract currently uses direct ownership transfer mechanisms. Using Ownable2Step ensures a safer transfer of ownership by requiring the new owner to accept ownership explicitly before it is finalized. This prevents accidental loss of ownership.

LowUse solmate’s safeTransferHelper insteadOpen

The contract currently uses a custom TransferHelper library for token transfers. Solmate’s SafeTransferLib is a more optimized and widely used alternative, providing better gas efficiency and security.