31Third - Diff - Update

Quantstamp4 Apr 2024Files named in the report

Quantstamp reviewed 31Third (31Third - Diff - Update) on 4 Apr 2024: 3 findings, 0 critical; 2 marked fixed, 1 acknowledged.

No open critical findings

Open the report Open 31Third’s security record

Report hosted on certificate.quantstamp.com.

Trustblock does not review code.

Findings3

Statuses are the security firm’s own, from its report.

Severity	Acknowledged	Fixed
Critical	0	0
High	0	0
Medium	0	0
Low	1	2

LowIndex Event Parameters for Improved Application MonitoringFixed

Application monitoring can be improved by indexing specific parameters emitted in an event. By indexing event parameters, off-chain systems can more easily filter contract logs by the indexed data. The following event parameters could benefit from indexing: 1. `GenericDifferentSpenderAdapter`: 1. `name`, `handlerAddress`, and `spenderAddress` in the event `GenericDifferentSpenderAdapterDeployed`. 2. `GenericBasicAdapter`: 1. `name` and `handlerAndSpenderAddress` in the event `GenericBasicAdapterDeployed`.

LowOptimizations and ImprovementsFixed

Certain changes can be made in order to improve the gas-efficiency of the contracts: 1. Use custom errors instead of `require()`. 2. The two contracts in scope are duplicates. Code duplication is detrimental as it leads to the maintenance of the same issues in different locations, and is therefore, error-prone. In the case of Solidity, it might also lead to larger bytecode which might hinder the deployment of the system. Consider using inheritance or only the `GenericDifferentSpenderAdapter` contract and slightly modify the constructor to manage the case of the `GenericBasicAdapter`.