Epoch Island - LP Pool

Quantstamp7 Nov 2023Files named in the report

Quantstamp reviewed Epoch Island (Epoch Island - LP Pool) on 7 Nov 2023: 14 findings, 0 critical; 6 marked fixed, 6 acknowledged, 2 open.

No open critical findings

Open the report Open Epoch Island’s security record

Report hosted on certificate.quantstamp.com.

Trustblock does not review code.

Findings14

Statuses are the security firm’s own, from its report.

Severity	Open	Acknowledged	Fixed
Critical	0	0	0
High	0	0	0
Medium	0	1	2
Low	2	5	4

LowApplication Monitoring Can Be Improved by Emitting More EventsOpen

For easiness of application development, it is helpful to have the most important information emitted by events at crucial state changes. The following informational content of events could be improved upon: 1. No event is emitted when `lpPositions` is deleted in L94. 1. The `Remove` event only contains the `positionId` which may lead to more complex information querying, especially when the value at that index was deleted. Consider adding the following parameters: `_upsideTokenAmount` and `_downsideTokenAmount`.

LowInsufficient User DocumentationOpen

We have observed some incidents of undocumented behavior that the user should be informed about: 1. The fee mechanism is undocumented and users are currently not informed how the fee changes over time. 1. While it makes sense, the documentation does not reflect that users will not receive any fees back when calling `untake()`. 1. While some NatSpec inline code documentation is provided, they do not describe function parameters and return values. Consider adding these, at least for all publicly and externally callable functions.