Galleon DEX

Quantstamp5 May 2021Files named in the report

Audit

Quantstamp reviewed Galleon DEX on 5 May 2021: 20 findings, 0 critical; 7 marked fixed, 11 acknowledged, 2 open.

No open critical findings

Open the report Open Galleon DEX’s security record

Report hosted on certificate.quantstamp.com.

Trustblock does not review code.

Findings20

Statuses are the security firm’s own, from its report.

Severity	Open	Acknowledged	Fixed
Critical	0	0	0
High	2	0	0
Medium	0	4	4
Low	0	7	3

HighInsuficient Test SuiteOpen

Branch coverage of some of the core contracts in this project is too low. For example, the branch coverage for the `GalleonPool` is 40% and 55% for the `GalleonExchangeInterface`. This means that there are several potential code execution flows, which are not tested to work as expected and could therefore work differently than expected.

HighThe Galleon DEX Owner May Arbitrarily Mint LP TokensOpen

The owner of the exchange pools may perform many privileged actions as described in the "Privileged Roles and Ownership" finding from this report. However, one privilege that stands out is that of arbitrarily minting LP tokens. Most of the other privileges are common in DeFi applications, but the arbitrary LP token minting makes this a High severity issue, because of the impact it may have on end-users holding LP tokens. By minting a large amount of LP tokens, the owner could withdraw a large number of deposited tokens from the Galleon pool, leaving depositors short-handed. This scenario is not necessarily assuming a malicious owner; it could very well be the case that the private key of the owner is stolen and the attacker does this. From the existing documentation and code comments, it is not clear to the auditors which use-case this arbitrary minting of LP tokens would be needed for.