TermMax. Phase II

ABDK ConsultingCode version: not recorded (see the report)

ABDK Consulting reviewed TermMax (TermMax. Phase II) on 7 Jul 2025: 14 findings, 0 critical; 10 marked fixed, 4 acknowledged.

No open critical findings
Open the reportOpen TermMax’s security record

Report hosted on GitHub.

Trustblock does not review code.

Findings68

Statuses are the security firm’s own, from its report.

SeverityOpenAcknowledgedFixed
Critical000
High000
Medium0410
Low000

Marked Recommendations by the firm. Not counted as findings.

RecommendationsBrackets are redundant.Acknowledged

The report gives no description here.

RecommendationsBrackets are redundant.Acknowledged

The report gives no description here.

RecommendationsBrackets areound multiplication are redundant.Acknowledged

The report gives no description here.

RecommendationsBrackets areound multiplication are redundant.Acknowledged

The report gives no description here.

RecommendationsConsider specifying as "^0.8.0" unless there is something special re- garding this particular version.Acknowledged

The report gives no description here.

RecommendationsEvents are usually named via nouns, such as "MinApySubmission" or "MinApy".Acknowledged

The report gives no description here.

RecommendationsIt would be more efficient to merge these two mappings into a single mapping whose keys re maturities and values are structs encapsulating the values of the ...Acknowledged

The report gives no description here.

RecommendationsIt would be more efficient to pass a single array of structs with four fields, rather than four parallel arrays.Acknowledged

The report gives no description here.

RecommendationsSolidity compiler is smart enough to precompute constant hash expressions.Acknowledged

The report gives no description here.

RecommendationsThe argument type should be more specific.Acknowledged

The report gives no description here.

Show 10 more
RecommendationsThe return type should be "ITermMaxVaultV2".Acknowledged

The report gives no description here.

RecommendationsThe return type should be "ITermMaxVaultV2".Acknowledged

The report gives no description here.

RecommendationsThe return type should be more specific.Acknowledged

The report gives no description here.

RecommendationsThe return type should be more specific.Acknowledged

The report gives no description here.

RecommendationsThe return type should be more specific.Acknowledged

The report gives no description here.

RecommendationsThe type for address parameters should be more specific.Acknowledged

The report gives no description here.

RecommendationsThe type for the "collateral" argument should be "IERC20".Acknowledged

The report gives no description here.

RecommendationsThe type for the "collateral" argument should be "IERC20".Acknowledged

The report gives no description here.

RecommendationsThe type for the "priceFeed" parameter should be more specific.Acknowledged

The report gives no description here.

RecommendationsThe type for the "vault" parameter should be more specific.Acknowledged

The report gives no description here.

Show 10 more
RecommendationsThe type for this argument should be "IERC20".Acknowledged

The report gives no description here.

RecommendationsThe type for this argument should be "IERC20".Acknowledged

The report gives no description here.

RecommendationsThe type for this variable should be more specific.Acknowledged

The report gives no description here.

RecommendationsThese names doesn't sound like errors.Acknowledged

The report gives no description here.

RecommendationsThis check is partially superseded by the "amount > badDebtAmt" check.Acknowledged

The report gives no description here.

RecommendationsThis check is redundant, as it will anyway be performed inside the "_burn" call.,Acknowledged

The report gives no description here.

RecommendationsThis error could be made more useful by adding certain parameters into it.Acknowledged

The report gives no description here.

RecommendationsThis error could be made more useful by adding certain parameters into it.Acknowledged

The report gives no description here.

RecommendationsUpdating interest incrementally could accumulate rounding errors.Acknowledged

The report gives no description here.

RecommendationsUPPER_CASE names are conventionally used for constants, but not for argu- ments.Acknowledged

The report gives no description here.

Show 10 more
RecommendationsUPPER_CASE names are conventionally used for constants, but not for vari- ables.Acknowledged

The report gives no description here.

RecommendationsUPPER_CASE names are conventionally used for constants.Acknowledged

The report gives no description here.

RecommendationsUPPER_CASE names are conventionally used for constants.Acknowledged

The report gives no description here.

RecommendationsWe didn't review these files.Acknowledged

The report gives no description here.

RecommendationsWe didn't review these files.Acknowledged

The report gives no description here.

RecommendationsWe didn't review these files.Acknowledged

The report gives no description here.

RecommendationsWe didn't review this file.Acknowledged

The report gives no description here.

RecommendationsWe didn't review this file.Acknowledged

The report gives no description here.

RecommendationsWe didn't review this file.Acknowledged

The report gives no description here.

RecommendationsEvents are usually named via nouns, such as "Market", "Vault", or "PriceFeed".  Fixed

The report gives no description here.

Show 10 more
RecommendationsIt is unclear how the remark in brackets is related to the main comment.Fixed

The report gives no description here.

RecommendationsIt would be more efficient to pass a single array of structs with four fields, rather than four parallel arrays.Fixed

The report gives no description here.

RecommendationsThe "_accretingPrincipal" variable is read twice.Fixed

The report gives no description here.

RecommendationsThe case when "changes" is exactly zero isn't handled.Fixed

The report gives no description here.

RecommendationsThe number format for the returned value is unclear.Fixed

The report gives no description here.

RecommendationsThe number format for these fields is unclear.Fixed

The report gives no description here.

RecommendationsThe number format of the arguments is unclear.Fixed

The report gives no description here.

RecommendationsThe semantics of the keys in this mapping is unclear.Fixed

The report gives no description here.

RecommendationsThis check is redundant, as it is anyway possible to pass a dead address.Fixed

The report gives no description here.

RecommendationsThis check is redundant, as it is anyway possible to pass a dead order manager address.  Fixed

The report gives no description here.

Show 4 more
RecommendationsThis check makes the "asset" argument redundant.Fixed

The report gives no description here.

RecommendationsThis file should be imported as "./VaultStorageV2.sol".  Fixed

The report gives no description here.

RecommendationsThis function should emit some event.  Fixed

The report gives no description here.

RecommendationsUnlike other similar cases, here even is emitted outside the setter call.Fixed

The report gives no description here.

Contracts in scope

No deployed address is recorded for this audit.

The report names a repository or files. Open the report to see its scope.

Part of TermMax’s security record

TermMax
Audits2 audits by 1 firmLast audit Dec 2025, by ABDK Consulting.
Critical findingsNo open critical findingsAcross the 2 reports, 1 critical finding was reported. It is marked fixed by the firm that reported it.
Open TermMax’s security record

Security firm

ABDK Consulting

34 projects reviewed · 73 reports · latest Jun 2026

See ABDK Consulting’s audits

Something wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.

Tell us