Let's Goal - Audit

CertiK17 Oct 2022Files named in the report

Audit

CertiK reviewed LetsGoal (Let's Goal - Audit) on 17 Oct 2022: 6 findings, 0 critical; 4 marked fixed, 2 open.

No open critical findings

Open the report Open LetsGoal’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings6

Statuses are the security firm’s own, from its report.

Severity	Open	Fixed
Critical	0	0
High	2	0
Medium	0	0
Low	0	4

LowMinor TyposFixed

1. Function `caluteTokenURI()` seems to contain a misspelled word. 2. Error message in function `reclaimTokenByAmount()` and `reclaimToken()` seems to contain gramma mistakes.

LowToken URI Uses HttpsFixed

The ERC1155 token URI uses "https://storage.googleapis.com/meli-games/". The availability of the URI depends on that third party server. It's recommended by OpenZeppelin to use IPFS for NFT token metadata rather than HTTP/HTTPS. For HTTP/HTTPS, the domain and web server owner can change token metadata at will to dramatically affect token value. See [https://docs.openzeppelin.com/contracts/4.x/erc1155](https://docs.openzeppelin.com/contracts/4.x/erc1155).

LowUnclear Usage of Pauser and ManagerFixed

Contract `FootBall` inherits `Pausable` and assigns a `PAUSER_ROLE` to flip the switch. However, the usage of pausing is not found within the contract. The contract does not behave differently when the switch is flipped. Meanwhile, the `MANAGER_ROLE` is set in the constructor but not used within scope of the contract.

LowVariables That Could Be Declared as `constant`Fixed

The linked variables could be declared as `constant` since these state variables are never modified.