Knox Locker

CertiKFiles named in the report

Audit

Part of CertiK’s series

CertiK reviewed SquidGrow (Knox Locker) on 15 Jun 2024: 18 findings, 0 critical; 11 marked fixed, 2 acknowledged, 5 open.

No open critical findings
Open the reportOpen SquidGrow’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings18

Statuses are the security firm’s own, from its report.

SeverityOpenAcknowledgedFixed
Critical000
High010
Medium011
Low5010
LowComposition of Fees Not BoundedOpen

The different fees in LPLock.sol are not correlated with each other and they could add up to more than 100% (even using different tokens), while it should be guaranteed that the fees are bound to a reasonable amount as a sum.

LowCostly Operation Inside LoopOpen

Reading, initializing, and modifying storage variables cost more gas than operating local variables, and this gas cost can significantly increase when these operations are performed inside a loop. Reference: https://docs.soliditylang.org/en/latest/introduction-to-smart-contracts.html#storage-memory-and-the-stack ```solidity=468 NONCE++; ```

LowMissing Emit EventsOpen

There should always be events emitted in the sensitive functions that are controlled by centralization roles.

LowPull-Over-Push PatternOpen

The contracts `KnoxLpLocker` and `KnoxTokenLocker` inherit functionalities from the `Ownable` contract such as the `transferOwnership()` that allows setting the new `owner` without guaranteeing the designated account is able to actuate transactions on-chain. A similar approach should be adopted for the `transferLockOwnership` function of both `vesting` and `LPLock` contracts in which the ownership of the lock is transferred to a `newOwner. If the `newOwner` cannot actuate transactions on-chain, the lock will be stuck forever.

LowUnused Return ValueOpen

The smart contract does not check or store the return value of an external call in a local or state variable, which may introduce vulnerabilities due to the unhandled outcome. ```solidity=164 feeWhitelist.add(_user); ``` --- ```solidity=166 feeWhitelist.remove(_user); ``` --- ```solidity=289 lockedTokens.add(_lpToken); ``` --- ```solidity=293 user.lockedTokens.add(_lpToken); ``` --- ```solidity=364 users[msg.sender].lockedTokens.remove(_lpToken); ``` --- ```solidity=470 user.lockedTokens.add(_lpToken); ``` --- ```solidity=479 users[msg.sender].lockedTokens.remove(_lpToken); ``` --- ```solidity=512 users[msg.sender].lockedTokens.remove(_lpToken); ``` --- ```solidity=517 migrator.migrate(_lpToken, _amount, userLock.unlockDate, msg.sender); ``` --- ```solidity=338 TOKEN_WHITELISTERS.add(_user); ``` --- ```solidity=340 TOKEN_WHITELISTERS.remove(_user); ``` --- ```solidity=358 ZERO_FEE_WHITELIST.add(_token); ``` --- ```solidity=369 ZERO_FEE_WHITELIST.add(_token); ``` --- ```solidity=371 ZERO_FEE_WHITELIST.remove(_token); ``` --- ```solidity=454 IUnlockCondition(lock_param.condition).unlockTokens(); ``` --- ```solidity=460 TOKENS.add(_token); ``` --- ```solidity=465 user.lockedTokens.add(_token); ``` --- ```solidity=665 newOwner.lockedTokens.add(transferredLock.tokenAddress); ```

Contracts in scope

No deployed address is recorded for this audit.

The report names a repository or files. Open the report to see its scope.

Repository and files the report names (2)

  • contracts/LPLock.sol
  • contracts/vesting.sol

Part of SquidGrow’s security record

SquidGrow
Audits16 audits by 2 firmsLast audit Sep 2024, by Hacken.
Critical findingsNo open critical findingsAcross the 16 reports, 1 critical finding was reported. It is marked fixed by the firm that reported it.
Open SquidGrow’s security record

Security firm

CertiK

1,045 projects reviewed · 1,376 reports · latest May 2025

See CertiK’s audits

Something wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.

Tell us