Magpie V2

In MagpieStargateBridgeV3, within the bridgeIn function, the quoteOFT is called to determine the expected amount of tokens received for the user after bridging (the minAmountLD variable). However, this amount is taken as is, without any extra check against the user's slippage. On the contrary, the MagpieCelerBridgeV2 has user supplied slippage implemented.

Within the MagpieRouterV3 contract the swapWithMagpieSignature allows the user to trigger swap operation, if only the user has been given the valid signature signed by the internalCaller. However, this signature-based authorisation is flawed as it does not include nonce in the signed message. As a result, user can replay the signature multiple times triggering multiple swap operations.This state persists until the internalCaller is not revoked.

The MagpieStargateBridgeV3 contract allows to perform swap and then bridge the obtained token to the Stargate. However, it does not check whether the provided bridge fee in native tokens is sufficient to fulfill the request. Thus, the transaction call can revert in the late processing consuming more Gas than required. Additionally, the contract does not expose any function to calculate the required amount of Gas off-chain.The Stargate implements LayerZero’s OFT standard. This protocol exposes quoteSend function, which can provide an amount of bridge fee required to fulfill the request. This function takes into account the size of  the SendParam.