Shift DeFi Platform Update

ABDK ConsultingCode version: not recorded (see the report)

ABDK Consulting reviewed Shift DeFi (Shift DeFi Platform Update) on 17 Jun 2026: 13 findings, 0 critical; 9 marked fixed, 4 acknowledged.

No open critical findings
Open the reportOpen Shift DeFi’s security record

Report hosted on GitHub.

Trustblock does not review code.

Findings80

Statuses are the security firm’s own, from its report.

SeverityOpenAcknowledgedFixed
Critical000
High000
Medium049
Low000

Marked Recommendation by the firm. Not counted as findings.

RecommendationBrackets are redundant. 19 + return (state & PROTOCOL_STATE_MASK) != 0; 22 + return (state & TOKEN_STATE_MASK) != 0; 26 + return (state & TARGET_STATE_MASK) ...Acknowledged

The report gives no description here.

RecommendationConsider grouping Open Zeppelin imports together. 4 + import {Initializable} from "@openzeppelin/contracts-upgradeable/ ↪ → proxy/utils/Initializable.sol"; 5...Acknowledged

The report gives no description here.

RecommendationConsider specifying as "^.8.0" unless there is something special regarding this particular version. 3 + pragma solidity ^0.8.28; 20 === page 21 ===Acknowledged

The report gives no description here.

RecommendationConsider specifying as "^0.8.0" unless there is something special regarding this particular version.Acknowledged

The report gives no description here.

RecommendationIt would be more efficient to pass a single array of structs with two fields, rather than two parallel arrays. This would also make the length check unneces-...Acknowledged

The report gives no description here.

RecommendationSemantics of the keys and values in this mappings is unclear.Acknowledged

The report gives no description here.

RecommendationSemantics of the returned values is unclear.Acknowledged

The report gives no description here.

RecommendationShould be "else if". 178 + if ( 185 + if ( 23 === page 24 ===Acknowledged

The report gives no description here.

RecommendationShould be "else if". 191 + if (messageType == Codec.WITHDRAWAL_RESPONSE_TYPE) {Acknowledged

The report gives no description here.

RecommendationShould be "else if". 325 + if ( 332 + if ( 22 === page 23 ===Acknowledged

The report gives no description here.

Show 10 more
RecommendationShould be "else revert" for readability, otherwise it looks like the func- tion always reverts. 201 + revert Codec.WrongMessageType(messageType); 24 === page...Acknowledged

The report gives no description here.

RecommendationShould be "else revert". 192 + revert Errors.IncorrectContainerStatus();Acknowledged

The report gives no description here.

RecommendationShould be "else revert". 340 + revert Errors.IncorrectContainerStatus();Acknowledged

The report gives no description here.

RecommendationThe argument type should be "IERC20". 123 + function setInputTokens( address [] calldata inputTokens) external ↪ → override onlyStrategyContainer { 135 + f...Acknowledged

The report gives no description here.

RecommendationThe argument type should be "IStrategyContainer". 112 + function __StrategyTemplate_init( address strategyContainer) ↪ → internal onlyInitializing { 29 === p...Acknowledged

The report gives no description here.

RecommendationThe error name is confusing, as there is no zero value here.Acknowledged

The report gives no description here.

RecommendationThe key type for this mapping should be "IERC20". 14 + mapping ( address => uint256 ) public tokenToPrice;Acknowledged

The report gives no description here.

RecommendationThe key type for this mapping should be "IERC20". 21 + mapping ( address => address ) public override priceOracles; 25 === page 26 ===Acknowledged

The report gives no description here.

RecommendationThe number format for the "price" argument is unclear.Acknowledged

The report gives no description here.

RecommendationThe number format for the price is unclear.Acknowledged

The report gives no description here.

Show 10 more
RecommendationThe number format for the returned value is unclear.Acknowledged

The report gives no description here.

RecommendationThe number format of the returned price is unclear.Acknowledged

The report gives no description here.

RecommendationThe particular format of the "path" argument is unclear.Acknowledged

The report gives no description here.

RecommendationThe return type should be "IERC20". 92 + function getInputTokens() external view override returns ( address [] ↪ → memory ) { 96 + function getOutputTokens()...Acknowledged

The report gives no description here.

RecommendationThe semantics of the keys and values in this mapping is unclear.Acknowledged

The report gives no description here.

RecommendationThe semantics of the keys and values in this mappings is unclear.Acknowledged

The report gives no description here.

RecommendationThe semantics of the retuned value is unclear.Acknowledged

The report gives no description here.

RecommendationThe semantics of the returned value is unclear.Acknowledged

The report gives no description here.

RecommendationThe semantics of the returned values is unclear.Acknowledged

The report gives no description here.

RecommendationThe semantics of the returned values is unclear.Acknowledged

The report gives no description here.

Show 10 more
RecommendationThe semantics of the returned values is unclear.Acknowledged

The report gives no description here.

RecommendationThe type for he keys in this mapping should be "IERC20". 20 + mapping ( address => mapping ( address => PredefinedSwapParameters)) ↪ → public predefinedSwapP...Acknowledged

The report gives no description here.

RecommendationThe type for the "food" argument should be "IChainlinkPriceFeed". 21 + function setChainlinkFeed( address token, address feed) external ↪ → override onlyRole...Acknowledged

The report gives no description here.

RecommendationThe type for the "priceOracle" argument should be "IPriceOracle". 34 + function setPriceOracle( address token, address priceOracle) ↪ → external override onl...Acknowledged

The report gives no description here.

RecommendationThe type for the "strategy" argument should be more specific. 39 + address strategy, 48 + address strategyAcknowledged

The report gives no description here.

RecommendationThe type for the "token" argument should be "IERC20". 21 + function setChainlinkFeed( address token, address feed) external ↪ → override onlyRole(ORACLE_MANA...Acknowledged

The report gives no description here.

RecommendationThe type for the "token" argument should be "IERC20". 34 + function setPriceOracle( address token, address priceOracle) ↪ → external override onlyRole(ORACLE...Acknowledged

The report gives no description here.

RecommendationThe type for the "token" argument should be "IERC20". 406 + function getTokenAmountInNotion( address token, uint256 amount) ↪ → public view returns ( uint256...Acknowledged

The report gives no description here.

RecommendationThe type for the "tokenIn" argument should be "IERC20". 502 + function _swapToInputTokens( address tokenIn, address tokenOut) ↪ → internal virtual {Acknowledged

The report gives no description here.

RecommendationThe type for the "tokens" argument should be "IERC20". 483 + function _tokensAmountsDump( address [] memory tokens, uint256 share) ↪ → private view returns...Acknowledged

The report gives no description here.

Show 10 more
RecommendationThe type for the token arguments should be "IERC20". 53 + function getRelativeValueUnified( address token0, address token1, ↪ → uint256 value0) external view...Acknowledged

The report gives no description here.

RecommendationThe type for these argument should be "IERC20". 40 + address [] calldata inputTokens, 41 + address [] calldata outputTokensAcknowledged

The report gives no description here.

RecommendationThe type for these argument should be "IERC20". 84 + address [] calldata inputTokens, 85 + address [] calldata outputTokensAcknowledged

The report gives no description here.

RecommendationThe type for these arguments should be "IERC20". 51 + address tokenIn, 52 + address tokenOut, 65 + address tokenIn, 66 + address tokenOut,Acknowledged

The report gives no description here.

RecommendationThe type for these arguments should be more specific. 83 + address strategy, 92 + address strategyAcknowledged

The report gives no description here.

RecommendationThe type for this argument should be more specific. 53 + address adapter,Acknowledged

The report gives no description here.

RecommendationThe type for this mapping should be: mapping IERC20 ⇒ IChain- linePriceFeed) 14 + mapping ( address => address ) public tokenToChainlinkFeed; 17 === page 18...Acknowledged

The report gives no description here.

RecommendationThe type for this variable should be "IERC20". 34 + address internal _notion; 28 === page 29 ===Acknowledged

The report gives no description here.

RecommendationThe type for this variable should be "IStrategyContainer". 33 + address internal _strategyContainer;Acknowledged

The report gives no description here.

RecommendationThe type fro the "token" argument should be "IERC20". 29 + function submitPrice( address token, uint256 price) external ↪ → onlyRole(FEEDER_ROLE) { 34 + func...Acknowledged

The report gives no description here.

Show 10 more
RecommendationThe value type for this mapping should be "IPriceOracle". 21 + mapping ( address => address ) public override priceOracles;Acknowledged

The report gives no description here.

RecommendationThe word "position" here is to generic and it is unclear, what kind of position is ment.Acknowledged

The report gives no description here.

RecommendationThese checks are redundant, as it is anyway possible to pass a dead token address. Remove these checks. 126 + require (inputTokens[i] != address (0), Errors....Acknowledged

The report gives no description here.

RecommendationThese checks are redundant, as it is anyway possible to pass dead token address. 56 + require (tokenIn != address (0), Errors.ZeroAddress()); 57 + require (t...Acknowledged

The report gives no description here.

RecommendationThis check is redundant, as it is anyway possible to pass a dead token address. 22 + require (token != address (0), Errors.ZeroAddress());Acknowledged

The report gives no description here.

RecommendationThis check is redundant, as it is anyway possible to pass a dead token address. 35 + require (token != address (0), Errors.ZeroAddress()); 26 === page 27 ===Acknowledged

The report gives no description here.

RecommendationThis check is redundant, as it is superseded by the "msg.sender" check in the next line. 49 + require (_strategyContainer != address (0), Errors.ZeroAddress());Acknowledged

The report gives no description here.

RecommendationThis check is redundant, as it is superseded by the following "chain- linkFeed" test. 31 + require (token != address (0), Errors.ZeroAddress());Acknowledged

The report gives no description here.

RecommendationThis check is redundant, as it is superseded by the following "priceO racle" check. 44 + require (token != address (0), Errors.ZeroAddress());Acknowledged

The report gives no description here.

RecommendationThis check optimizes a rare use case (zero amount) while making common case less efficient.Acknowledged

The report gives no description here.

Show 7 more
RecommendationThis check should be dome earlier. 156 + if (isTargetState) { 157 + require (_targetStateId == bytes32 (0), TargetStateAlreadySet());Acknowledged

The report gives no description here.

RecommendationThis condition could be simplified as: !_isTargetState || _isProtocol- State || _isTokenState). 42 + if (!_isTargetState && !_isProtocolState && !_isTokenSt...Acknowledged

The report gives no description here.

RecommendationThis error could be made more useful by adding certain parameters into it. 15 +error InconsistentState();Acknowledged

The report gives no description here.

RecommendationWe didn't review these files. 5 + import {IPriceOracle} from "../interfaces/IPriceOracle.sol"; 6 + import {ICustomOracleWrapper} from "../interfaces/ ↪ → ICu...Acknowledged

The report gives no description here.

RecommendationWe didn't review these files. 8 + import {IChainlinkPriceFeed} from "../dependencies/interfaces/ ↪ → chainlink/IChainlinkPriceFeed.sol"; 9 + import {IChainli...Acknowledged

The report gives no description here.

RecommendationWe didn't review this file. 10 + import {IPriceOracleAggregator} from "./interfaces/ ↪ → IPriceOracleAggregator.sol";Acknowledged

The report gives no description here.

RecommendationWe didn't review this file. 18 + import {IPriceOracleAggregator} from "./interfaces/ ↪ → IPriceOracleAggregator.sol";Acknowledged

The report gives no description here.

Contracts in scope

No deployed address is recorded for this audit.

The report names a repository or files. Open the report to see its scope.

Part of Shift DeFi’s security record

Shift DeFi
Audits1 audit by 1 firmLast audit Jun 2026, by ABDK Consulting.
Critical findingsNo open critical findingsIn 1 report.
Open Shift DeFi’s security record

Security firm

ABDK Consulting

34 projects reviewed · 73 reports · latest Jun 2026

See ABDK Consulting’s audits

Something wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.

Tell us