Nostra Pools

Cairo Security Clan1 Jan 2024Files named in the report

Audit

Cairo Security Clan reviewed Nostra (Nostra Pools) on 1 Jan 2024: 9 findings, 0 critical; 7 marked fixed, 2 open.

No open critical findings

Open the report Open Nostra’s security record

Report stored on IPFS. Content hash bafkreia6byys6rpcxjtodou65uf4w2hlyc5u7orfilskb62owdr23iebli

Trustblock does not review code.

Findings9

Statuses are the security firm’s own, from its report.

Severity	Open	Fixed
Critical	0	0
High	0	0
Medium	0	0
Low	2	7

LowSelector callback balanceof is unnecessaryFixed

In the current Starknet version, failed transactions always revert the whole transaction, so handling reverted external calls with selector callback balanceof is unnecessary. Recommendation is to consider using camel case function names.

LowSelector callback for transferfrom is unnecessaryFixed

In the current Starknet version, failed transactions always revert the whole transaction, so handling reverted external calls with selector callback for transferfrom is unnecessary. Recommendation is to consider using camel case function names.

LowSwap fee can be higher than the limitFixed

Swap_fee parameter is passed directly into the constructor of the pair contract; however, it can be higher than 10000 and causes swap errors in the pair contract. Recommendation is to consider checking swap_fee before deploying the pair.

LowUnnecessary assert statementFixed

The report gives no description here.

LowUnnecessary storage writingsFixed

The report gives no description here.

LowUse internal traits for internal contract methodsFixed

The report gives no description here.

LowWrong Starknet version specified in scarb.tomlFixed

The Starknet version in scarb config is wrong and mismatches with other dependencies. Recommendation is to consider changing the Starknet version in scarb.toml to 2.4.0.