DODO Mining

CertiK31 Mar 2021Files named in the report

Audit

CertiK reviewed DODO AMM (DODO Mining) on 31 Mar 2021: 8 findings, 0 critical; all marked fixed.

No open critical findings

Open the report Open DODO AMM’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings8

Statuses are the security firm’s own, from its report.

Severity	Open	Acknowledged	Fixed
Critical	0	0	0
High	0	0	0
Medium	0	0	0
Low	0	0	8

LowCode Optimization for Function BaseMine.removeRewFixed

If i equal to len-1,we don't need to execute code `rewardTokenInfos[i] = rewardTokenInfos[len - 1];`.

LowDiscussion For Function BaseMine.claimReward() anFixed

We notice that the function `RewardVault.reward()` can only be executed by the owner. But in function `BaseMine.claimReward()` the reward is transfered to `msg.sender`. So how can other users claim their own rewards. Is there any other implementation of `IRewardVault.reward()`.

LowDiscussion For function vDODOMine.syncBalance()Fixed

Please introduce when will the function `vDODOMine.syncBalance()` be executed and what will happen.

LowMissing Emit EventsFixed

Function `vDODOMine.syncBalance()` should be able to emit events as notifications to customers because it change the status of sensitive variables.

LowMissing Transfer ProcessFixed

Contract `vDODOMine` missing transfer process in function `deposit()` and `withdraw()`.

LowProper Usage of “public” And “external” TypeFixed

`public` functions that are never called by the contract could be declared `external`.

LowWrong Parameter of RequireFixed

When `rewardToken` not found in function `BaseMine.getIdByRewardToken()`, it should return a warning message.But according to the logic,it won't return anything.

LowWrong Warning MessageFixed

Wrong Warning message of check in function `BaseMine.getRewardTokenById()`: ``` require(i<rewardTokenInfos.length, "DODOMineV2: REWARD_ID_FOUND");