NAOS-Formation Updates

QuantstampFiles named in the report

Quantstamp reviewed NAOS (NAOS-Formation Updates) on 17 Nov 2021: 4 findings, 0 critical; all marked fixed.

No open critical findings
Open the reportOpen NAOS’s security record

Report hosted on certificate.quantstamp.com.

Trustblock does not review code.

Findings4

Statuses are the security firm’s own, from its report.

SeverityOpenAcknowledgedFixed
Critical000
High000
Medium001
Low003
Medium`amountOutMin` too low in `swapExactTokensForTokens` callFixed

The call `uniV2Router.swapExactTokensForTokens(alpacaToken.balanceOf(address(this)), 0, path, address(this), block.timestamp + 800);` sets the `amountOutMin` value to 0. If the pool is out-of-balance or manipulated in an unfavorable way (possibly through a [sandwich-attack](https://medium.com/coinmonks/defi-sandwich-attack-explain-776f6f43b2fd)), the swap may result in very few `bUSD` tokens being withdrawn.

LowMissing `ensureUserActionDelay` modifierFixed

The related [TransmuterB.sol](https://github.com/alchemix-finance/alchemix-protocol/blob/master/contracts/TransmuterB.sol) contract utilizes an `ensureUserActionDelay` modifier, as implemented [here](https://github.com/alchemix-finance/alchemix-protocol/blob/14344a0386351b374da061122e1f5caf8e421afc/contracts/TransmuterB.sol#L330). This guards functions `stake`, `transmute`, and `forceTransmute`, and may mitigate unforeseen attacks such as flash loan attacks.

LowUnchecked return valuesFixed

The following functions have return values that are not checked: 1. AlpacaVaultAdapter.withdraw(address,uint256) (contracts/adapters/AlpacaVaultAdapter.sol#124-133) ignores return value by busdToken.transfer(_recipient,busdToken.balanceOf(address(this))) (contracts/adapters/AlpacaVaultAdapter.sol#132) 1. AlpacaVaultAdapter.indirectWithdraw(address,uint256) (contracts/adapters/AlpacaVaultAdapter.sol#141-161) ignores return value by busdToken.transfer(_recipient,busdToken.balanceOf(address(this))) (contracts/adapters/AlpacaVaultAdapter.sol#160) 1. Formation._distributeToTransmuter(uint256) (contracts/Formation.sol#593-598) ignores return value by token.approve(transmuter,amount) (contracts/Formation.sol#594) 1. FormationV2._distributeToTransmuter(uint256) (contracts/FormationV2.sol#600-605) ignores return value by token.approve(transmuter,amount) (contracts/FormationV2.sol#601) 1. TransmuterV2._plantOrRecallExcessFunds() (contracts/TransmuterV2.sol#687-702) ignores return value by _activeVault.deposit(plantAmt) (contracts/TransmuterV2.sol#695) 1. TransmuterV2.migrateFunds(address) (contracts/TransmuterV2.sol#797-807) ignores return value by IERC20Burnable(Token).approve(migrateTo,migratableFunds) (contracts/TransmuterV2.sol#804) 1. AlpacaVaultAdapter.indirectWithdraw(address,uint256) (contracts/adapters/AlpacaVaultAdapter.sol#141-161) ignores return value by uniV2Router.swapExactTokensForTokens(alpacaToken.balanceOf(address(this)),0,path,address(this),block.timestamp + 800) (contracts/adapters/AlpacaVaultAdapter.sol#151-157) 1. YearnVaultAdapter.deposit(uint256) (contracts/adapters/YearnVaultAdapter.sol#63-65) ignores return value by vault.deposit(_amount) (contracts/adapters/YearnVaultAdapter.sol#64) 1. YearnVaultAdapter.withdraw(address,uint256) (contracts/adapters/YearnVaultAdapter.sol#73-75) ignores return value by vault.withdraw(_tokensToShares(_amount),_recipient) (contracts/adapters/YearnVaultAdapter.sol#74)

LowUnlocked PragmaFixed

Every Solidity file specifies in the header a version number of the format `pragma solidity (^)0.4.*`. The caret (`^`) before the version number implies an unlocked pragma, meaning that the compiler will use the specified version _and above_, hence the term "unlocked".

Contracts in scope

No deployed address is recorded for this audit.

The report names a repository or files. Open the report to see its scope.

Repository and files the report names (49)

  • contracts/interfaces/ICurveMetaFactory.sol
  • contracts/adapters/EllipsisVaultAdapter.sol
  • contracts/interfaces/IERC20Burnable.sol
  • contracts/adapters/YearnVaultAdapterV2.sol
  • contracts/FormationV2.sol
  • contracts/interfaces/IYearnController.sol
  • contracts/interfaces/IMintableERC20.sol
  • contracts/mocks/EllipsisPoolMock.sol
  • contracts/interfaces/ITransmuter.sol
  • contracts/interfaces/IyVaultV2.sol
  • contracts/mocks/IbBUSDMock.sol
  • contracts/mocks/VaultAdapterV2Mock.sol
  • contracts/mocks/YearnVaultMock.sol
  • contracts/Transmuter.sol
  • contracts/interfaces/IUniswapV2Router.sol
  • contracts/interfaces/IVaultAdapterV2.sol
  • contracts/MultiSigWalletWithTimelock.sol
  • contracts/interfaces/I3ESPool.sol
  • contracts/StakingPools.sol
  • contracts/mocks/YearnVaultMockUSD.sol
  • contracts/interfaces/IAlpacaVaultConfig.sol
  • contracts/adapters/AlpacaVaultAdapter.sol
  • contracts/libraries/formation/VaultV2.sol
  • contracts/libraries/formation/CDP.sol
  • contracts/adapters/YearnVaultAdapter.sol
  • contracts/mocks/VaultAdapterMock.sol
  • contracts/NAOSToken.sol
  • contracts/mocks/ERC20Mock.sol
  • contracts/interfaces/IDetailedERC20.sol
  • contracts/libraries/pools/Stake.sol
  • contracts/MultiSigWallet.sol
  • contracts/libraries/pools/Pool.sol
  • contracts/NToken.sol
  • contracts/mocks/AlpacaStakingPoolMock.sol
  • contracts/interfaces/IAlpacaPool.sol
  • contracts/TransmuterV2.sol
  • contracts/interfaces/IChainlink.sol
  • contracts/Formation.sol
  • contracts/mocks/ERC20MockUSD.sol
  • contracts/libraries/formation/Vault.sol
  • contracts/interfaces/IYearnVault.sol
  • contracts/mocks/UniswapV2Mock.sol
  • contracts/mocks/YearnControllerMock.sol
  • contracts/mocks/I3ESPoolMock.sol
  • contracts/interfaces/IVaultAdapter.sol
  • contracts/libraries/FixedPointMath.sol
  • contracts/interfaces/IbBUSDToken.sol
  • contracts/interfaces/IEllipsisPool.sol
  • contracts/mocks/AlpacaVaultConfigMock.sol

Part of NAOS’s security record

NAOS
Audits2 audits by 1 firmLast audit Nov 2021, by Quantstamp.
Critical findingsNo open critical findingsAcross 2 reports.
Open NAOS’s security record

Security firm

Quantstamp

236 projects reviewed · 332 reports · latest Oct 2026

See Quantstamp’s audits

Something wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.

Tell us