Iskra - ItemNFTSnapshot

CertiK14 Aug 2023Files named in the report

CertiK reviewed Iskra (Iskra - ItemNFTSnapshot) on 14 Aug 2023: 4 findings, 0 critical; 1 marked fixed, 1 acknowledged, 2 open.

No open critical findings

Open the report Open Iskra’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings4

Statuses are the security firm’s own, from its report.

Severity	Open	Acknowledged	Fixed
Critical	0	0	0
High	0	1	0
Medium	0	0	0
Low	2	0	1

LowBatchminting does not prevent overflowOpen

The function `ERC721._mint()` updates the receiver balance as follows: ```solidity unchecked { // Will not overflow unless all 2**256 token ids are minted to the same owner. // Given that tokens are minted one by one, it is impossible in practice that // this ever happens. Might change if we allow batch minting. // The ERC fails to describe this case. _balances[to] += 1; } ``` In theory, the function `safeMintBatch()` could cause an overflow.

LowRedundant Code ComponentsOpen

In the ERC721Snapshot contract, a counter variable `_currentSnapshotId` is defined but never utilized. Although the internal function `_snapshot()` incrementing this counter is present, it is not invoked within the scope of the audited code. Additionally, the function `_getCurrentSnapshotId()`, which retrieves the counter's value, is overridden in the `ItemNFTSnapshot` contract, thus ensuring that `_currentSnapshotId` remains unused throughout