Superpower Squad - New Deal

CertiKFiles named in the report

CertiK reviewed Superpower Squad (Superpower Squad - New Deal) on 9 Dec 2022: 16 findings, 0 critical; 3 marked fixed, 1 acknowledged, 12 open.

No open critical findings
Open the reportOpen Superpower Squad’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings16

Statuses are the security firm’s own, from its report.

SeverityOpenAcknowledgedFixed
Critical000
High010
Medium000
Low1203
LowInconsistency Risk with `_tokenIdCounter`Open

In the contract `HERC721IMLogic.sol`, the variable `_tokenIdCounter` is used when minting a token with the zero id, to set automatically the right number as the id of the token minted. \ However, this only works if `tokenId == 0`, if not then `tokenId` can be set freely, and the `_tokenIdCounter` will not be updated. Moreover, the function `setTokenIdCounter()` allows a privileged address to completely change the counter. This could create inconsistencies about the count of tokens, and unexpected mistakes when minting a token.

LowLogical Issue with Freezing FeatureOpen

The `HERC721IMLogic.sol` allows freezing tokens using the functions `_freezeNormal()` and `_freezeSudo()`. \ Both functions allow freezing a `tokenId` multiple times. In addition to that, `_freezeSudo()` allows freezing a non-yet minted `tokenId`. ----- Also, the freezing functions will lock a token and store the address of an `unlocker`. However, the purpose of this parameter is unclear and seems to never be used outside of the freeze/thaw functions.

LowMissing Emit EventsOpen

There should always be events emitted in sensitive functions that are controlled by centralization roles.

LowMissing Error MessagesOpen

The `revert()` statements should provide a description of the condition not met. The `require()` statements can be used to check for conditions and throw an exception if the condition is not met. It is better to provide a string message containing details about the error that will be passed back to the caller.

LowOut of Scope DependenciesOpen

Many contracts are importing or inheriting files outside of the audit scope. The scope of the audit treats these entities as black boxes and assumes their functional correctness. However, in the real world, these contracts could be compromised and this may lead to lost or stolen assets.

LowPotential OverflowOpen

In the contract `HERC20IMLogic.sol`, the function `_beforeTokenTransfer()` updates the `uint _transferAmounts` variable as follow: ```solidity=140 unchecked{_transferAmounts = _transferAmounts + amount;} ``` Since this operation takes place inside an `unchecked{}` block, an overflow could happen.

LowRedundant Code ComponentsOpen

The linked statements do not affect the functionality of the codebase and appear to be either leftovers from test code or older functionality.

LowUnnecessary Use of SafeMathOpen

The `SafeMath` library is used unnecessarily. With Solidity compiler versions 0.8.0 or newer, arithmetic operations will automatically revert in case of integer overflow or underflow.

LowUnsafe Type CastOpen

```solidity=375 return address(uint160(uint256(_fixedAttribute[attributeName][tokenId]))); ``` - The type conversion `uint160(uint256(_fixedAttribute[attributeName][tokenId]))` from larger type uint256 to smaller type uint160 may truncate data. --- ```solidity=381 ret[i] = address(uint160(uint256(_fixedAttribute[attributeName[i]][tokenId]))); ``` - The type conversion `uint160(uint256(_fixedAttribute[attributeName[i]][tokenId]))` from larger type uint256 to smaller type uint160 may truncate data. --- ```solidity=48 return address(uint160(uint256(delegatesSlot.sysUniqueIndexMapGetValue(index)))); ``` - The type conversion `uint160(uint256(delegatesSlot.sysUniqueIndexMapGetValue(index)))` from larger type uint256 to smaller type uint160 may truncate data. --- ```solidity=95 return address(uint160(uint256(adminSlot.sysLoadSlotData()))); ``` - The type conversion `uint160(uint256(adminSlot.sysLoadSlotData()))` from larger type uint256 to smaller type uint160 may truncate data.

LowUnused Return ValueOpen

The return value of an external call is not stored in a local or state variable.

Show 2 more
LowUse of `EnhancedMap` LibraryOpen

Library `EnhancedMap` does not appear to be used within any of the audited files. This library contains functions which update files on a low-level, and, depending on how they are used, can present vulnerabilities within a contract with which it is used.

LowUse of `sysSaveSlotData()`Open

In the library `SlotData.sol`, the function `sysSaveSlotData()` allows the registration of any data in any slot number. \ If this function is not restricted enough it could present vulnerabilities as using EVM assembly is extremely error-prone.

Contracts in scope

No deployed address is recorded for this audit.

The report names a repository or files. Open the report to see its scope.

Repository and files the report names (41)

  • contracts/dependant/erc20improved/HERC20IMLogic.sol
  • contracts/tokens/squad/SquadEvent.sol
  • contracts/dependant/erc721/HERC721Layout.sol
  • contracts/dependant/erc20improved/HERC20IMEvent.sol
  • contracts/tokens/squad/SquadLayout.sol
  • contracts/nfts/ssh/SSHType.sol
  • contracts/dependant/proxy/EnhancedUniqueIndexMap.sol
  • contracts/tokens/squad/SquadInterface.sol
  • contracts/nfts/ssh/SSHLayout.sol
  • contracts/dependant/erc20/HERC20Event.sol
  • contracts/dependant/erc721improved/HERC721IMType.sol
  • contracts/dependant/erc721/HERC721ReceiverInterface.sol
  • contracts/nfts/ssh/SSHEvent.sol
  • contracts/dependant/proxy/Delegate.sol
  • contracts/dependant/proxy/EnhancedMap.sol
  • contracts/dependant/erc20/HERC20Storage.sol
  • contracts/dependant/erc721/HERC721Logic.sol
  • contracts/tokens/squad/SquadType.sol
  • contracts/nfts/ssh/SSHInterface.sol
  • contracts/dependant/erc20/HERC20Layout.sol
  • contracts/dependant/proxy/Proxy.sol
  • contracts/dependant/proxy/Base.sol
  • contracts/dependant/erc721improved/HERC721IMStorage.sol
  • contracts/dependant/erc721improved/HERC721IMLayout.sol
  • contracts/dependant/erc20improved/HERC20IMType.sol
  • contracts/dependant/erc20improved/HERC20IMLayout.sol
  • contracts/tokens/squad/SquadStorage.sol
  • contracts/dependant/erc721improved/HERC721IMInterface.sol
  • contracts/dependant/erc721/HERC721Storage.sol
  • contracts/dependant/erc721/HERC721Event.sol
  • contracts/nfts/ssh/SSHLogic.sol
  • contracts/tokens/squad/SquadLogic.sol
  • contracts/dependant/proxy/SlotData.sol
  • contracts/dependant/erc721/HERC721Interface.sol
  • contracts/dependant/erc20/HERC20Logic.sol
  • contracts/dependant/erc721improved/HERC721IMEvent.sol
  • contracts/dependant/erc20improved/HERC20IMInterface.sol
  • contracts/dependant/erc20/HERC20Interface.sol
  • contracts/nfts/ssh/SSHStorage.sol
  • contracts/dependant/erc721improved/HERC721IMLogic.sol
  • contracts/dependant/erc20improved/HERC20IMStorage.sol

Part of Superpower Squad’s security record

Superpower Squad
Audits1 audit by 1 firmLast audit Dec 2022, by CertiK.
Critical findingsNo open critical findingsIn 1 report.
Open Superpower Squad’s security record

Security firm

CertiK

1,045 projects reviewed · 1,376 reports · latest May 2025

See CertiK’s audits

Something wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.

Tell us