USDFI Dex & Miner - Audit

CertiK12 Sep 20221 address on BNB Chain

CertiK reviewed USDFI (USDFI Dex & Miner - Audit) on 12 Sep 2022: 7 findings, 0 critical; 5 marked fixed, 1 acknowledged, 1 open.

No open critical findings

Open the report Open USDFI’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings7

Statuses are the security firm’s own, from its report.

Severity	Open	Acknowledged	Fixed
Critical	0	0	0
High	0	1	0
Medium	0	0	0
Low	1	0	5

LowDivide Before MultiplyFixed

Performing integer division before multiplication truncates the low bits, losing the precision of calculation. ```solidity=73 uint256 bal = checkMining().div(10000).mul(percent[i]); ``` --- ```solidity=81 uint256 bal = checkMining().div(10000).mul(percentPanic[i]); ``` --- ```solidity=90 uint256 receivedWantTokens = IERC20(wantToUSDFI[1]) .balanceOf(address(this)) .div(100000) .mul(mintingFee); ```

LowImproper Usage of `public` and `external` TypeFixed

`public` functions that are never called by the contract could be declared as `external`. `external` functions are more efficient than `public` functions.

LowMissing Zero Address ValidationFixed

Addresses should be checked before assignment or external call to make sure they are not zero addresses. ```solidity=122 receiverAddress = _receiverAddress; ``` - `_receiverAddress` is not zero-checked before being used. --- ```solidity=130 receiverMintFeeAddress = _receiverMintFeeAddress; ``` - `_receiverMintFeeAddress` is not zero-checked before being used.

LowUnchecked ERC-20 `transfer()`/`transferFrom()` CaFixed

The return value of the transfer()/transferFrom() call is not checked. ```solidity=95 IERC20(wantToUSDFI[1]).transfer(receiverAddress, receivedWantTokens); ``` --- ```solidity=104 IERC20(wantToUSDFI[1]).transfer( receiverMintFeeAddress, receivedWantTokens ); ```

LowVariables That Could Be Declared as `constant`Fixed

The linked variables could be declared as `constant` since these state variables are never modified.