ErcProtocol

One or more declarations do not conform to the [Solidity style guide](https://solidity.readthedocs.io/en/v0.7.3/style-guide.html#naming-conventions) with regards to its naming convention. Particularly: - `camelCase`: Should be applied to function names, argument names, local and state variable names, modifiers - `UPPER_CASE`: Should be applied to `constant` variables - `CapWords`: Should be applied to contract names, struct names, event names and enums ```solidity=40 uint32 public constant minimumTimeBetweenMints = 1 days * 365; ``` - Constant variable `minimumTimeBetweenMints` is not in `UPPER_CASE`. --- ```solidity=43 uint8 public constant mintCap = 2; ``` - Constant variable `mintCap` is not in `UPPER_CASE`. --- ```solidity=135 function _initialize(address timelock_) public { ``` - Function `_initialize` is not in `camelCase`. --- ```solidity=313 function GRACE_PERIOD() external view returns (uint); ``` - Function `GRACE_PERIOD` is not in `camelCase`.

The function should check if the transaction is already canceled. Otherwise, the transaction can be canceled many times and the event can be generated many times.

Addresses should be checked before assignment or external call to make sure they are not zero addresses. ```solidity=84 minter = minter_; ``` - `minter_` is not zero-checked before being used. --- ```solidity=96 minter = minter_; ``` - `minter_` is not zero-checked before being used. --- ```solidity=132 guardian = guardian_; ``` - `guardian_` is not zero-checked before being used. --- ```solidity=37 target = target_; ``` - `target_` is not zero-checked before being used. --- ```solidity=31 admin = admin_; ``` - `admin_` is not zero-checked before being used. --- ```solidity=56 pendingAdmin = pendingAdmin_; ``` - `pendingAdmin_` is not zero-checked before being used. --- ```solidity=100 (bool success, bytes memory returnData) = target.call{value: value}(callData); ``` - `target` is not zero-checked before being used.

The signature malleability is possible within the Elliptic Curve cryptographic system. An Elliptic Curve is symmetric on the X-axis, meaning two points can exist with the same `X` value. In the `r`, `s`, and `v` representation this permits us to carefully adjust `s` to produce a second valid signature for the same `r`, thus breaking the assumption that a signature cannot be replayed in what is known as a replay-attack.

The return value of the transfer()/transferFrom() call is not checked. ```solidity=64 token_.transfer(target_, toDrip_); ```

The `SafeMath` library is used unnecessarily. With Solidity compiler versions 0.8.0 or newer, arithmetic operations will automatically revert in case of integer overflow or underflow.