BitDCA

In the linked locations, events are emitted after external calls. This does not adhere to the Check-Effects-Interactions Pattern, which recommends emitting events before making external calls as a best practice.

If an event is not indexed in a smart contract, it means that the event's parameters are not tagged with the `indexed` keyword. This has implications for how the event data can be searched and filtered when looking through blockchain logs. Without indexing, the event will still emit the data as part of the transaction log, but users won't be able to query for these events using the parameters. They'll have to retrieve the entire set of logs and manually sift through them to find events with the specific data. This can be less efficient and more time-consuming, especially on a blockchain with a high volume of transactions and events.

The function `BDCAVestingCEX.setVesting()` requires that the vesting process has not yet started. However, the `BDCAVestingCEX.startVesting()` function can be called before `BDCAVestingCEX.setVesting()` is executed. This creates a situation where `BDCAVestingCEX.setVesting()` becomes uncallable, effectively leaving the vault without any allocation settings. As a result, the contract may become non-functional.