CertiK reviewed Arca by Smart-Chain (Arca by Smart-Chain - Audit) on 23 Jan 2023: 6 findings, 1 critical; 1 marked fixed, 1 acknowledged, 4 open.
Report hosted on skynet.certik.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 1 |
| High | 0 | 1 | 0 |
| Medium | 0 | 0 | 0 |
| Low | 4 | 0 | 0 |
When transferring deflationary ERC20 tokens, the input amount may not be equal to the received amount due to the charged transaction fee. For example, if a user sends 100 deflationary tokens (with a 10% transaction fee), only 90 tokens actually arrived to the contract. However, a failure to discount such fees may allow the same user to withdraw 100 tokens from the contract, which causes the contract to lose 10 tokens in such a transaction. Reference: https://thoreum-finance.medium.com/what-exploit-happened-today-for-gocerberus-and-garuda-also-for-lokum-ybear-piggy-caramelswap-3943ee23a39f ```solidity=125 IERC20(indexedAssetAddress).safeTransferFrom( msg.sender, address(this), amountOfAssetToRedeem ); ``` - Transferring tokens by `amountOfAssetToRedeem`. ```solidity=130 IERC20(indexedAssetAddress).burn(amountOfAssetToRedeem); ``` - The `amountOfAssetToRedeem` appears to be used for bookkeeping purposes without compensating the potential transfer fees. - Note: `burn` is an external function and its behavior wasn't evaluated.
In the `redeemBasketForAssetAmount` function, a user can redeem assets by invoking the `redeemBasketForAssetAmount` function and burning the corresponding `indexedAssetAddress` token: ```solidity=104 function redeemBasketForAssetAmount(uint256 amountOfAssetToRedeem) external nonReentrant { ... IERC20(indexedAssetAddress).burn(amountOfAssetToRedeem); ... IERC20(assetBasketAddress).safeTransfer( msg.sender, redeemAmountForAsset ); ... ``` However, when the `redeemAmountForAsset` for each asset becomes zero, the `redeemBasketForAssetAmount` becomes a kind of `burn` function. A similar scenario happened in the `ArcaERC721` contract for the `redeemBasketForAssetAmount` function.
There should always be events emitted in the sensitive functions that are controlled by centralization roles.
Addresses should be checked before assignment or external call to make sure they are not zero addresses. ```solidity=97 indexedAssetAddress = initialIndexedAssetAddress; ``` - `initialIndexedAssetAddress` is not zero-checked before being used. --- ```solidity=186 indexedAssetAddress = newIndexedAssetAddress; ``` - `newIndexedAssetAddress` is not zero-checked before being used. --- ```solidity=196 collectiveTreasuryAddress = newCollectiveTreasuryAddress; ``` - `newCollectiveTreasuryAddress` is not zero-checked before being used. --- ```solidity=98 indexedAssetAddress = initialIndexedAssetAddress; ``` - `initialIndexedAssetAddress` is not zero-checked before being used. --- ```solidity=189 indexedAssetAddress = newIndexedAssetAddress; ``` - `newIndexedAssetAddress` is not zero-checked before being used. --- ```solidity=199 collectiveTreasuryAddress = newCollectiveTreasuryAddress; ``` - `newCollectiveTreasuryAddress` is not zero-checked before being used.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (2)
1,045 projects reviewed · 1,376 reports · latest May 2025
See CertiK’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us