Part of CertiK’s retainer series
CertiK reviewed WEMIX (Wemix Retainer 48 PlayNFTMarket) on 7 Sep 2023: 30 findings, 0 critical; 19 marked fixed, 11 open.
Report hosted on skynet.certik.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 0 |
| High | 2 | 0 | 1 |
| Medium | 1 | 0 | 3 |
| Low | 8 | 0 | 15 |
In the contract `PlayMarketRecipient`, the roles `editor` and `owner` have authority over the following functions: - function setTokenManagerAddress(): set `tokenManagerAddress`. - function setTreasuryAddress(): set the fee address `_treasury`. - function setMaxFee(): set `maxFee`. Any compromise to the `editor` or `owner` account may allow a hacker to take advantage of this authority and change fee settings. In the contract `PlayMarketRecipient`, the role `tokenManagerAddress` has authority over the following functions: - function setRecipient(): set fee recipient addresses. - function distributionEventEmit(): emit `DistributionEvent`. Any compromise to the `tokenManagerAddress` account may allow a hacker to take advantage of this authority. --- In the contract `PlayMarketTokenManager`, the roles `editor` and `owner` have authority over the following functions: - function registerCollection(): register ERC721 or ERC1155 contract that can be traded on market. - function modifyCollection(): modify registered collection. - function modifyCollectionFee(): modify registered collection's fee info. - function blockCollection(): block a collection. - function unblockCollection(): unblock a collection. Any compromise to the `editor` or `owner` account may allow a hacker to take advantage of this authority and manage collections. --- In the contracts `PlayMarketBase`, the roles `editor` and `owner` have authority over the following functions: - function addStrategy(): add or modify strategy to the market. - function subStrategy(): inactivate strategy in the market. - function setPriceOracle(): set price oracle contract. - function setTokenManagerAddress(): set `tokenManager` contract address. - function setPaymentToken(): set payment token. Any compromise to the `editor` or `owner` account may allow a hacker to take advantage of this authority. --- In the contracts `PlayMarketBaseV2`, the roles `editor` and `owner` have authority over the following functions: - function addStrategy(): add or modify strategy to the market. - function subStrategy(): inactivate strategy in the market. - function setPriceOracle(): set price oracle contract. - function setTokenManagerAddress(): set `tokenManager` contract address. - functions addPaymentToken() and removePaymentToken(): manage payment tokens. Any compromise to the `editor` or `owner` account may allow a hacker to take advantage of this authority. --- In the contract `PlayMarketEnglishAuctionOrder`, the roles `editor` and `owner` have authority over the function setMinimumStartPrice() to set the minimum price for the auction price order. Any compromise to the `editor` or `owner` account may allow a hacker to take advantage of this authority. In the contract `PlayMarketEnglishAuctionOrder`, the role `market` has authority over the following functions: - function open(): open an auction. - function offer(): place a bid in an auction. - function cancel(): cancel an auction or bid. - function claim(): the bid winner claims NFT. Any compromise to the `market` account may allow a hacker to take advantage of this authority. --- In the contract `PlayMarketFixedPriceOrder`, the role `market` has authority over the following functions: - function open(): open a sell order. - function offer(): accept a sale order. - function cancel(): cancel an order. - function modify(): update an order. Any compromise to the `market` account may allow a hacker to take advantage of this authority. --- In the contract `PlayMarketOpenPriceOrder`, the role `market` has authority over the following functions: - function open(): open a buy order. - function offer(): accept a buy order. - function cancel(): cancel an order. - function modify(): update an order. Any compromise to the `market` account may allow a hacker to take advantage of this authority. --- In the contracts `LzPlayNFT721` and `PlayNFT721`, the role `owner` has authority over the following functions: - function mint(): mint a non-wrapped NFT. - function mintBatch(): mint multiple non-wrapped NFTs. - function setPlayBridge(): set the `_playBridge` address. - function setTokenIdURI(): set the token's metadata URI. - function setBaseURI(): set the collection's base URI. Any compromise to the `owner` account may allow a hacker to take advantage of this authority. In the contracts `LzPlayNFT721` and `PlayNFT721`, the role `_playBridge` has authority over the following functions: - function mint(): mint wrapped NFT. - function mintBatch(): mint multiple wrapped NFTs. Any compromise to the `_playBridge` account may allow a hacker to take advantage of this authority. --- In the contracts `LzPlayNFT1155` and `PlayNFT1155`, the role `owner` has authority over the following functions: - function mint(): mint non-wrapped ERC1155 token. - function mintBatch(): mint multiple non-wrapped ERC1155 tokens. - function setPlayBridge(): set the `_playBridge` address. - function setTokenIdURI(): set the token's metadata URI. -
In the contracts `PlayMarketTokenManager`, `PlayMarketBase`, `PlayMarketBaseV2`, and `PlayOpenMarket`, the proxy admin has the authority to update the implementation contract behind the proxy contracts. Any compromise to the admin account may allow a hacker to take advantage of this authority and control the implementation contract which is pointed by proxy and therefore execute potential malicious functionality in the implementation contract.
The `Checker.checkBalance()` function is used to ensure that the token amount received by the strategy contracts is equal to the NFT price. However, if the strategy contracts have any existing token balances before the transaction, the balance check could be incorrect. ```solidity=59 function checkBalance(address token, uint value) internal view returns (bool) { uint balance; if (token == address(0)) { balance = address(this).balance; } else { balance = IERC20(token).balanceOf(address(this)); } return balance >= value; } ```
The NFT market stores order information, including the NFT price, in the `PlayNFTMarketOracle` contract. However, users can list their NFTs on the market for trading and can specify any price for their NFTs. This situation opens the possibility for malicious users to engage in price manipulation by paying fees and trading with different wallets. As a consequence, any protocols relying on the NFT price provided by the `PlayNFTMarketOracle` are potentially not safe.
There is no upper limit restricting parameter of `modifyCollectionFee()` and the maximum fee in the `PlayMarketRecipient` contract is 100%, potentially enabling up to 100% of fees on transactions.
In the `PlayMarketBase` contract, payable functions `registerBuyOrder()`, `offerBuyOrder()` and `claimAuction()` are able to receive native tokens, but their functionality does not depend on native tokens, and the contract does not have a withdrawal function, which could result in tokens being locked.
The `registerSellOrder()` function lacks of a sanity check to ensure the order price is not zero.
Opened orders are saved in the `_orderIDsBySeller[]` but they are never removed, for example, the order is completed or canceled.
The contract serves as the underlying entity to interact with `PriceOracle` contract. The scope of the audit treats contract that is out of scope as black boxes and assumes their functional correctness. However, in the real world, those contracts can be compromised.
The modifier `nonReentrant` is not applied to the function `PlayOpenMarket.cancelSellOfferBuy()` to prevent reentrance attacks.
An auction will end if there is no new bid after the designated close delay of the auction order. If the seller hasn't called `setCloseDelay()` to change the close delay, the default close delay for an auction order is zero. Consequently, the auction will conclude after the first bid.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (28)
1,045 projects reviewed · 1,376 reports · latest May 2025
See CertiK’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us