THE Protocol ($THE) - Audit

In the contract `Ownable` the role `_owner` has authority over the functions shown in the diagram below. Any compromise to the `_owner` account may allow the hacker to take advantage of this authority and change the ownership of the contract.  In the contract `THEPROTOCOL` the role `_owner` has authority over the functions shown in the diagram below. Any compromise to the `_owner` account may allow the hacker to take advantage of this authority and change the configuration of the contract.  Additionally, There are some wallets, i.e. `marketingWallet`, `devWallet`, which gather ETH on each call to `swapBack()` function, over time, these wallets would gain a lot of ETH.

Addresses should be checked before assignment or external call to make sure they are not zero addresses. ```solidity=1287 marketingWallet = newMarketingWallet; ``` - `newMarketingWallet` is not zero-checked before being used. --- ```solidity=1292 devWallet = newWallet; ``` - `newWallet` is not zero-checked before being used.

When calculating the token balance of `to` address after the transfer, the `amount` is with fees. The token balance of the receiver may not exceed the max wallet without including the fees. ```solidity require(amount + balanceOf(to) <= maxWallet, "Max wallet exceeded"); ```

When accumulating the fees in function `_transfer()`, the variables `tokensForLiquidity`, `tokensForDev` and `tokensForMarketing` are calculating as below. However, `tokensForLiquidity + tokensForDev + tokensForMarketing` may be less than `fees` in this way because of the loss of accuracy. ```solidity=1417 // on sell if (automatedMarketMakerPairs[to] && sellTotalFees > 0){ fees = amount.mul(sellTotalFees).div(100); tokensForLiquidity += fees * sellLiquidityFee / sellTotalFees; tokensForDev += fees * sellDevFee / sellTotalFees; tokensForMarketing += fees * sellMarketingFee / sellTotalFees; } // on buy else if(automatedMarketMakerPairs[from] && buyTotalFees > 0) { fees = amount.mul(buyTotalFees).div(100); tokensForLiquidity += fees * buyLiquidityFee / buyTotalFees; tokensForDev += fees * buyDevFee / buyTotalFees; tokensForMarketing += fees * buyMarketingFee / buyTotalFees; } ```