Saffron Staking V2

When smart contracts are deployed or their associated functions are invoked, the execution of these operations always consumes a certain quantity of gas, according to the amount of computation required to accomplish them. Modifying an unknown-size array that grows in size over time can result in a Denial of Service attack. Simply by having an excessively huge array, users can exceed the gas limit, therefore preventing the transaction from ever succeeding.

It is unclear how tokens are deposited to `SFIRewarder`. However, we recommend adding a dedicated function that calls `ERC20.transferFrom()` to avoid any address input error when handling the transfer.

The smart contract will use the `deposit()` function to send deposit assets from the user's account to the pool. When transferring ordinary ERC20 tokens, asset transfers work as expected, and the internal account balances are always consistent with the ERC20 token contract's real token balances. However, in the case of deflationary tokens, the input amount may differ from the returned amount due to the charges transaction fee, which can result in unexpected balance inconsistencies when comparing internal asset records to external ERC20 tokens contracts.

Enough `SFI` reward tokens need to be present in the `SFIRewarder` contract, otherwise, the reward payouts fail due to `safeSFITransfer` failing. As it is called on each claim (`deposit`, `withdraw`), users might not be able to claim their already allocated and pending rewards. Note that partial rewards are not paid out and the contract always tries to pay out the full rewards.