Carbify - Aco2Rewards

QuillAudits17 Aug 2023Files named in the report

Audit · firm’s term: audit report

QuillAudits reviewed Business Carbify (Carbify - Aco2Rewards) on 17 Aug 2023: 3 findings, 0 critical; all marked fixed.

No open critical findings

Open the report Open Business Carbify’s security record

Report hosted on quillaudits.com.

Trustblock does not review code.

Findings3

Statuses are the security firm’s own, from its report.

Severity	Open	Acknowledged	Fixed
Critical	0	0	0
High	0	0	0
Medium	0	0	0
Low	0	0	3

LowAdditional Check for Zero Address Cost High Gas ConsumptionFixed

In the burn and mint functions, there were two checks to prevent that the to address and account addresses are not a null address and the second check is to prevent minting and burning of zero amount. While the second check is appropriate, the present of the first check will hike the cost of gas for calling these functions. The _mint and _burn functions from the ERC20 openzeppelin library already has this check to prevent minting or burning

LowRemoved Unused Interfaces in Both ContractsFixed

There are a few imports made in both contracts to be used but were not called within them.In Aoc2 - ICRC.sol In NFTree - IERC721EnumerableUpgradable and ITree

LowUnlocked pragma ( pragma solidity ^0.8.17 )Fixed

Contracts should be deployed with the same compiler version and flags that they have been tested with thoroughly. Locking the pragma helps to ensure that contracts do not accidentally get deployed using, for example, an outdated compiler version that might introduce bugs that affect the contract system negatively.