CertiK reviewed Core (Core DAO) on 28 Oct 2022: 13 findings, 0 critical; 8 marked fixed, 1 acknowledged, 4 open.
Report hosted on skynet.certik.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 0 |
| High | 0 | 1 | 0 |
| Medium | 0 | 0 | 0 |
| Low | 4 | 0 | 8 |
`setAllowance()` currently poses a risk of a race condition. Consider the scenario: 1. `operator` is allowed to `applyFunds()` up to 1000. 2. `dao` wants to increase the allowance by 100 and calls `setAllowance(1100)`. 3. However, before this transaction was executed, `operator` calls `applyFunds(1000)`. 4. After the allowance is increased, `operator` calls `applyFunds(1100)`. 5. In total `operator` has spent 2100 which was not expected by `dao`.
The order of external calls or transfers and storage manipulation in a function should follow the check-effect-interaction pattern. Here, `si.endTime` is updated to `block.timestamp` after an external call to `DAO_TREASURY`. Moreover, it appears that nothing is preventing this function from being called more than once, updating `si.endTime` each time it is called.
There are several hardcoded addresses in the contracts of `Coredao` that cannot be verified until the blockchain is launched.
The use of Solidity's `transfer()` and `send()` functions are not recommended for transferring Ether, since some contracts may not be able to receive the funds. These functions forward only a fixed amount of gas (2300 specifically) and the receiving contracts may run out of gas before finishing the transfer. Additionally, EVM instructions' gas costs may increase in the future. Thus, some contracts that can receive now may stop working in the future due to the gas limitation. ```solidity=84 target.transfer(amount); ``` - `AirdropPool._reclaimTo` uses `transfer()`. --- ```solidity=143 DAO_TREASURY.transfer(amount); ``` - `CORESales.finishSale` uses `transfer()`. --- ```solidity=112 target.transfer(unreleased); ``` - `TeamVesting._releaseTo` uses `transfer()`.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (4)
1,045 projects reviewed · 1,376 reports · latest May 2025
See CertiK’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us