MCDEX Arbitrum Integration
Summary
We have reviewed the code, documentation, and test suite and found several issues of various severities. Overall, we consider the code to be well-written and with sufficient documentation and an extensive testing suite. We have outlined suggestions to better follow best practices, and recommend addressing all the findings to tighten the contracts for future deployments or contract updates. We also provide suggestions for improvements to follow the best practices. We recommend addressing all the **9** findings and the rest of the suggestions to harden the contracts for future deployments or contract updates. We recommend against deploying the code as-is. <br><br> **After reaudit:** Quantstamp has performed a reaudit to check the proposed fixes. All of the previously identified issues were either resolved (5 issues) or acknowledged (4 issues). Tests are very exhaustive but the output is still very verbose and can be confusing to read. There are 3 tests of 345 tests that are still failing.
Issues (9)
Low | Medium | High | Critical | Total | |
|---|---|---|---|---|---|
Not fixed | 3 | 2 | - | - | 5 |
Acknowledged | - | - | - | - | 0 |
Fixed | 4 | - | - | - | 4 |
| Total | 7 | 2 | 0 | 0 | 9 |