CertiK reviewed CloudTx (Cloudtx Finance) on 1 May 2023: 15 findings, 0 critical; 1 marked fixed, 3 acknowledged, 11 open.
Report hosted on skynet.certik.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 0 |
| High | 0 | 2 | 0 |
| Medium | 0 | 1 | 0 |
| Low | 11 | 0 | 1 |
The ` set_New_Router_and_Make_Pair()` function does not check if the pair has been created. If the pair has already been created, then calling `createPair()` on the factory contract will always cause this function to revert, making it impossible to update the router to this address.
When `process_Tokens_Now`, the contract owner may select the percent of the `cloudTx` token holding in the contract to swap. When the input amount `percent_Of_Tokens_To_Process` is larger than 100, the value `percent_Of_Tokens_To_Process` will be modified to 100 to avoid unexpected failure due to insufficient tokens. However, the current assignment statement uses "==" for the assignment which will be invalid. ```solidity=852 if (percent_Of_Tokens_To_Process > 100){percent_Of_Tokens_To_Process == 100;} ```
The transaction may be charged fees, so the max holding of the receiver should be the sum of the held tokens and the amount received from the transfer. The fees should not be included in the max holding. ```solidity=764 require((heldTokens + amount) <= _maxWalletToken,"You are trying to buy too many tokens. You have reached the limit for one wallet.");} ``` - Max holding is checked. ```solidity=935 (uint256 tTransferAmount, uint256 tDev) = _getValues(tAmount); ``` - Receiving amount is adjusted. ```solidity=937 _tOwned[recipient] = _tOwned[recipient].add(tTransferAmount); ``` - Balance is increased by the adjusted amount.
When updating `_owner` and `Wallet_Dev` to new addresses in the following methods: - `renounceOwnership()` - `transferOwnership(address newOwner)` - `Wallet_Update_Dev(address payable wallet)` The `_isExcludeFee` identifier is not removed from the original addresses.
Addresses should be checked before assignment or external call to make sure they are not zero addresses. ```solidity=585 Wallet_Dev = wallet; ``` - `wallet` is not zero-checked before being used. --- ```solidity=909 uniswapV2Pair = newPair; ``` - `newPair` is not zero-checked before being used.
A sandwich attack might happen when an attacker observes a transaction swapping tokens or adding liquidity without setting restrictions on slippage or minimum output amount. The attacker can manipulate the exchange rate by frontrunning (before the transaction being attacked) a transaction to purchase one of the assets and make profits by back running (after the transaction being attacked) a transaction to sell the asset. The following functions are called without setting restrictions on slippage or minimum output amount, so transactions triggering these functions are vulnerable to sandwich attacks, especially when the input amount is large: - `uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens()`
State variables that never change should be declared as `constant` to save gas. ```solidity=386 address payable private Wallet_Burn = payable(0x000000000000000000000000000000000000dEaD); ``` - `Wallet_Burn` should be declared `constant`. --- ```solidity=387 address payable private Wallet_zero = payable(0x0000000000000000000000000000000000000000); ``` - `Wallet_zero` should be declared `constant`. --- ```solidity=395 string private _name = "CloudTx"; ``` - `_name` should be declared `constant`. --- ```solidity=396 string private _symbol = "Cloud"; ``` - `_symbol` should be declared `constant`. --- ```solidity=397 uint8 private _decimals = 9; ``` - `_decimals` should be declared `constant`. --- ```solidity=398 uint256 private _tTotal = 200000000 * 10**9; ``` - `_tTotal` should be declared `constant`. --- ```solidity=399 uint256 private _tFeeTotal; ``` - `_tFeeTotal` should be declared `constant`. --- ```solidity=407 uint256 private maxPossibleFee = 80; ``` - `maxPossibleFee` should be declared `constant`.
The contracts cited have an unlocked compiler version. An unlocked compiler version in the source code of the contract permits the user to compile it at or above a particular version. This, in turn, leads to differences in the generated bytecode between compilations due to differing compiler version numbers. This can lead to ambiguity when debugging, as compiler specific bugs may occur in the codebase that would be hard to identify over a span of multiple compiler versions rather than a specific one.
The `SafeMath` library is used unnecessarily. With Solidity compiler versions 0.8.0 or newer, arithmetic operations will automatically revert in case of integer overflow or underflow.
One or more state variables are never used in the codebase. Variable `Wallet_zero` in `CloudTx` is never used in `CloudTx`. ```solidity=387 address payable private Wallet_zero = payable(0x0000000000000000000000000000000000000000); ``` ```solidity=364 contract CloudTx is Context, IERC20, Ownable { ``` --- Variable `_tFeeTotal` in `CloudTx` is never used in `CloudTx`. ```solidity=399 uint256 private _tFeeTotal; ``` ```solidity=364 contract CloudTx is Context, IERC20, Ownable { ``` --- Variable `_previousMaxWalletToken` in `CloudTx` is never used in `CloudTx`. ```solidity=427 uint256 private _previousMaxWalletToken = _maxWalletToken; ``` ```solidity=364 contract CloudTx is Context, IERC20, Ownable { ``` --- Variable `_previousMaxTxAmount` in `CloudTx` is never used in `CloudTx`. ```solidity=431 uint256 private _previousMaxTxAmount = _maxTxAmount; ``` ```solidity=364 contract CloudTx is Context, IERC20, Ownable { ```
It is not recommended to use Solidity's `transfer()` and `send()` functions for transferring Ether, since some contracts may not be able to receive the funds. Those functions forward only a fixed amount of gas (2300 specifically) and the receiving contracts may run out of gas before finishing the transfer. Also, EVM instructions' gas costs may increase in the future. Thus, some contracts that can receive now may stop working in the future due to the gas limitation. ```solidity=837 wallet.transfer(amount); ``` - `CloudTx.sendToWallet` uses `transfer()`.
| Address | Chain | Source code |
|---|---|---|
| 0xffad…def20xffad7f9f704a5fdc6265e24b436b4b35ed52def2 | Chain: BNB Chain | Source code: Verified source |
1,045 projects reviewed · 1,376 reports · latest May 2025
See CertiK’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us