Wemix Retainer 100 PlayNFTMarket (hybrid-auction)

CertiKFiles named in the report

Audit

Part of CertiK’s retainer series

CertiK reviewed WEMIX (Wemix Retainer 100 PlayNFTMarket (hybrid-auction)) on 1 Mar 2024: 8 findings, 0 critical; 5 marked fixed, 3 open.

No open critical findings
Open the reportOpen WEMIX’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings8

Statuses are the security firm’s own, from its report.

SeverityOpenAcknowledgedFixed
Critical000
High100
Medium101
Low104
MediumThe first bid in a Dutch auction can be lower thaFixed

The contract allows the first bid to be made at either the initial `_order.price` or the next decreased price calculated by `nextDecPrice()`. This does not align with the typical Dutch auction model, where the price should only decrease after a specified period (close delay) has elapsed from the auction's start time. ```solidity=71 require(_order.price == amount || (amount >= nextDecPrice(_order.payment, _order.price) && isValidPrice(_order.payment, amount)), "HA : first bid should be start price or bigger"); ``` Consequently, bidders can opt to bid on a lower price, and the order start price is not consistent with the logic in `orderStartPrice()` function.

LowComment InconsistencyFixed

```solidity=35 // setCloseDelay() * Requirements * - caller must have Editor role of the contract ``` - Instead of the `Editor` role, sellers can call the `setCloseDelay()` function. --- Incorrect Error Message ```solidity=42 require(delayTime >= minimumDelayTime, "AOB: minimun delay time is 1 hour"); ``` - The `minimumDelayTime` is not constantly 1 hour. ```solidity=50 function setCollectionCloseDelay(address _collection, uint _delay) external onlyEditor { require(_delay >= minimumDelayTime, "AOB: minimum delay time is 1 hour"); //minimun = 1hour ``` - The `minimumDelayTime` is not constantly 1 hour. The error message and comment both are inaccurate. ```solidity=39 // PlayMarketEnglishAuctionOrderV4 require(order.concludedTime >= minimumDelayTime, "AC : minimun delay time is 1 hour"); ``` - The `minimumDelayTime` is not constantly 1 hour. ```solidity=39 // PlayMarketHybridAuctionOrder require(order.concludedTime >= minimumDelayTime, "HA : minimum delay time is 1 hour"); ``` - The `minimumDelayTime` is not constantly 1 hour. Furthermore, there is a typo in messages that "minimun" should be "minimum".

LowGet the length of a numberFixed

```solidity=275 uint digit = bytes(Strings.toString(current)).length; ``` The approach to obtaining the length of a number can be optimized.

LowInadequate checking in `isAuctionStarted()` functFixed

The `isAuctionStarted()` function incorrectly returns `true` for an order that does not exist. This is due to the function checking whether `_order.startTime <= block.timestamp`. Since `_order.startTime` defaults to zero for a non-existing order, the comparison `0 <= block.timestamp` is always true, leading to the incorrect conclusion that the auction has started.

LowSellers can set close delay for an ongoing auctioFixed

The `PlayMarketAuctionOrderBase::setCloseDelay()` function is intended to restrict the modification of an order's close delay to a period before the auction starts. However, the function uses an incorrect conditional check to determine if the auction has started: ```solidity=40 require(_endTime[orderID] < type(uint).max, "AOB: set order's close delay is only available before auction start"); ``` This check is flawed because `_endTime[orderID]` is initially set to `type(uint).max` when an order is open (PlayMarketAuctionOrderBase, L155), and it is updated to a smaller value when a bidder places a bid: ```solidity=89 // PlayMarketEnglishAuctionOrderV4::offer() _endTime[orderID] = current + _closeDelay[_order.orderID]; ``` As a result, the condition allows sellers to change the order's close delay even after a bid has been made, contradicting the error message and the intended functionality.

Contracts in scope

No deployed address is recorded for this audit.

The report names a repository or files. Open the report to see its scope.

Repository and files the report names (3)

  • PlayNFTMarket/contracts/order/PlayMarketEnglishAuctionOrderV4.sol
  • PlayNFTMarket/contracts/order/PlayMarketHybridAuctionOrder.sol
  • PlayNFTMarket/contracts/order/PlayMarketAuctionOrderBase.sol

Part of WEMIX’s security record

WEMIX
Audits75 audits by 1 firmLast audit Feb 2025, by CertiK.
Critical findingsNo open critical findingsAcross the 75 reports, 17 critical findings were reported. Each is marked fixed by the firm that reported it.
Open WEMIX’s security record

Security firm

CertiK

1,045 projects reviewed · 1,376 reports · latest May 2025

See CertiK’s audits

Something wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.

Tell us