Part of CertiK’s retainer series
CertiK reviewed WEMIX (Wemix Retainer 100 PlayNFTMarket (hybrid-auction)) on 1 Mar 2024: 8 findings, 0 critical; 5 marked fixed, 3 open.
Report hosted on skynet.certik.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 0 |
| High | 1 | 0 | 0 |
| Medium | 1 | 0 | 1 |
| Low | 1 | 0 | 4 |
The contract allows the first bid to be made at either the initial `_order.price` or the next decreased price calculated by `nextDecPrice()`. This does not align with the typical Dutch auction model, where the price should only decrease after a specified period (close delay) has elapsed from the auction's start time. ```solidity=71 require(_order.price == amount || (amount >= nextDecPrice(_order.payment, _order.price) && isValidPrice(_order.payment, amount)), "HA : first bid should be start price or bigger"); ``` Consequently, bidders can opt to bid on a lower price, and the order start price is not consistent with the logic in `orderStartPrice()` function.
```solidity=35 // setCloseDelay() * Requirements * - caller must have Editor role of the contract ``` - Instead of the `Editor` role, sellers can call the `setCloseDelay()` function. --- Incorrect Error Message ```solidity=42 require(delayTime >= minimumDelayTime, "AOB: minimun delay time is 1 hour"); ``` - The `minimumDelayTime` is not constantly 1 hour. ```solidity=50 function setCollectionCloseDelay(address _collection, uint _delay) external onlyEditor { require(_delay >= minimumDelayTime, "AOB: minimum delay time is 1 hour"); //minimun = 1hour ``` - The `minimumDelayTime` is not constantly 1 hour. The error message and comment both are inaccurate. ```solidity=39 // PlayMarketEnglishAuctionOrderV4 require(order.concludedTime >= minimumDelayTime, "AC : minimun delay time is 1 hour"); ``` - The `minimumDelayTime` is not constantly 1 hour. ```solidity=39 // PlayMarketHybridAuctionOrder require(order.concludedTime >= minimumDelayTime, "HA : minimum delay time is 1 hour"); ``` - The `minimumDelayTime` is not constantly 1 hour. Furthermore, there is a typo in messages that "minimun" should be "minimum".
```solidity=275 uint digit = bytes(Strings.toString(current)).length; ``` The approach to obtaining the length of a number can be optimized.
The `isAuctionStarted()` function incorrectly returns `true` for an order that does not exist. This is due to the function checking whether `_order.startTime <= block.timestamp`. Since `_order.startTime` defaults to zero for a non-existing order, the comparison `0 <= block.timestamp` is always true, leading to the incorrect conclusion that the auction has started.
The `PlayMarketAuctionOrderBase::setCloseDelay()` function is intended to restrict the modification of an order's close delay to a period before the auction starts. However, the function uses an incorrect conditional check to determine if the auction has started: ```solidity=40 require(_endTime[orderID] < type(uint).max, "AOB: set order's close delay is only available before auction start"); ``` This check is flawed because `_endTime[orderID]` is initially set to `type(uint).max` when an order is open (PlayMarketAuctionOrderBase, L155), and it is updated to a smaller value when a bidder places a bid: ```solidity=89 // PlayMarketEnglishAuctionOrderV4::offer() _endTime[orderID] = current + _closeDelay[_order.orderID]; ``` As a result, the condition allows sellers to change the order's close delay even after a bid has been made, contradicting the error message and the intended functionality.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (3)
1,045 projects reviewed · 1,376 reports · latest May 2025
See CertiK’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us