XRPL AMM Addendum

CertiK15 Aug 2023Code version: not recorded (see the report)

Audit

CertiK reviewed XRP Ledger (XRPL AMM Addendum) on 15 Aug 2023: 4 findings, 0 critical; 3 marked fixed, 1 acknowledged.

No open critical findings

Open the report Open XRP Ledger’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings4

Statuses are the security firm’s own, from its report.

Severity	Acknowledged	Fixed
Critical	0	0
High	0	0
Medium	0	0
Low	1	3

LowPotential overflow in `cleanupOnAccountDelete()`Fixed

```cpp=1567 if (maxNodesToDelete && ++deleted > *maxNodesToDelete) ``` `maxNodesToDelete` is `std::optional<uint16_t>`, `deleted` is `uint16_t`. If `maxNodesToDelete == 65535` and there are enough entries in the account directory, the `deleted` will overflow and the code will not work as expected. `maxDeletableAMMTrustLines` passed to `cleanupOnAccountDelete()` is `size_t` set `512`. The ledger allows more than 65535 entries in the account directory according to `View.cpp::confineOwnerCount()`.

LowTyposFixed

There are typos in the code: - "truslines" is supposed to be "trustlines" - "view" is supposed to be "View"

LowUsage of Magic NumbersFixed

Magic numbers are used as-is in code.