STFX

CertiK12 Dec 2022Files named in the report

CertiK reviewed STFX on 12 Dec 2022: 16 findings, 0 critical; 3 marked fixed, 13 acknowledged.

No open critical findings

Open the report Open STFX’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings16

Statuses are the security firm’s own, from its report.

Severity	Acknowledged	Fixed
Critical	0	0
High	1	0
Medium	1	0
Low	11	3

LowLogical issue in function `depositInfoFund()`Fixed

The comment of the function `depositIntoFund()` says that amount has to be between `minInvestmentAmount` and `maxInvestmentAmount`. But the implementation seems not to align with the design. As per the implementation, `minInvestmentAmount` represents for the lower limit of one investment. However, `maxInvestmentAmount` represents the upper limit of the total investments.

LowLogical issue of creating stfFixed

We understand that the protocol needs to publicize the manager's investment strategy at the beginning of the creation, which is beneficial to gain the trust of users. While the users can copy the strategy from the events and open positions themselves to avoid fees, which might be unfair to those experienced managers.

LowLogical issue of function `createNewStf()`Fixed

The managers have to raise money before opening the position. But if they raised no money or a little, it might be a waste of gas to open a position or create the `stf` contract. So it might be better to create the `stf` contract when the manager is really about to invest.