Shell Protocol
Consensys reviewed Shell Protocol on 1 Jun 2020: 19 findings, 0 critical; all marked fixed.
Report hosted on diligence.security.
Trustblock does not review code.
Findings19
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 0 |
| High | 0 | 0 | 4 |
| Medium | 0 | 0 | 8 |
| Low | 0 | 0 | 7 |
HighAssimilators should implement an interfaceFixed
The report gives no description here.
HighCertain functions lack input validation routinesFixed
The report gives no description here.
HighRemove Loihi methods that can be used as backdoors by the administratorFixed
The report gives no description here.
HighUnexpected response in an assimilator’s external call can lock-up the whole systemFixed
The report gives no description here.
MediumAccess to assimilators does not check for existence and allows delegation to the zeroth addressFixed
The report gives no description here.
MediumAssimilators do not conform to the ERC20 specificationFixed
The report gives no description here.
MediumMath library’s fork has problematic changesFixed
The report gives no description here.
MediumRemove commented out code from the repositoryFixed
The report gives no description here.
MediumRemove debugging code from the repositoryFixed
The report gives no description here.
MediumShould check if the asset already exists when adding a new assetFixed
The report gives no description here.
Show 9 more
MediumTests should not failFixed
The report gives no description here.
MediumUse one file for each contract or libraryFixed
The report gives no description here.
LowCheck return values for both internal and external callsFixed
The report gives no description here.
LowCode coverage should be close to 100%Fixed
The report gives no description here.
LowConsider emitting an event when changing the frozen state of the contractFixed
The report gives no description here.
LowFunction supportsInterface can be restricted to pureFixed
The report gives no description here.
LowInterfaces do not need to be implemented for the compiler to access their selectors.Fixed
The report gives no description here.
LowUse consistent interfaces for functions in the same groupFixed
The report gives no description here.
LowUse more consistent function naming (includeAssimilator / excludeAdapter)Fixed
The report gives no description here.
Contracts in scope
No deployed address is recorded for this audit.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (27)
- src/assimilators/mainnet/asusdReserves/mainnetASusdToASusdAssimilator.sol
- src/assimilators/mainnet/usdtReserves/localUsdtToUsdtAssimilator.sol
- src/assimilators/mainnet/cdaiReserves/mainnetDaiToCDaiAssimilator.sol
- src/assimilators/mainnet/cusdcReserves/mainnetCUsdcToCUsdcAssimilator.sol
- src/assimilators/mainnet/susdReserves/MainnetASusdToSUsdAssimilator.sol
- src/assimilators/mainnet/susdReserves/MainnetSUsdToSUsdAssimilator.sol
- src/assimilators/mainnet/usdcReserves/localCUsdcToUsdcAssimilator.sol
- src/assimilators/mainnet/usdtReserves/localAUsdtToUsdtAssimilator.sol
- src/Loihi.sol
- src/assimilators/mainnet/daiReserves/mainnetDaiToDaiAssimilator.sol
- src/assimilators/aaveResources/ILendingPoolAddressesProvider.sol
- src/assimilators/mainnet/cdaiReserves/mainnetCDaiToCDaiAssimilator.sol
- src/Assimilators.sol
- src/assimilators/mainnet/asusdReserves/mainnetSUsdToASUsdAssimilator.sol
- src/ShellsExternal.sol
- src/Shells.sol
- src/assimilators/AssimilatorMath.sol
- src/assimilators/mainnet/daiReserves/mainnetChaiToDaiAssimilator.sol
- src/assimilators/mainnet/ausdtReserves/mainnetUsdtToAUsdtAssimilator.sol
- src/assimilators/mainnet/cusdcReserves/mainnetUsdcToCUsdcAssimilator.sol
- src/assimilators/mainnet/daiReserves/mainnetCDaiToDaiAssimilator.sol
- src/assimilators/mainnet/usdcReserves/localUsdcToUsdcAssimilator.sol
- src/assimilators/aaveResources/ILendingPool.sol
- src/Controller.sol
- src/LoihiRoot.sol
- src/assimilators/mainnet/ausdtReserves/mainnetAUsdtToAUsdtAssimilator.sol
- src/assimilators/mainnet/cdaiReserves/mainnetChaiToCDaiAssimilator.sol
Part of Shell Protocol’s security record
Shell ProtocolSecurity firm
Consensys41 projects reviewed · 59 reports · latest Oct 2024
See Consensys’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us