Glory Finance

CertiK23 Feb 2023Files named in the report

Audit

CertiK reviewed Glory Finance on 23 Feb 2023: 21 findings, 3 critical; 18 marked fixed, 1 acknowledged, 2 open.

3 critical findings, fixed

Open the report Open Glory Finance’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings21

Statuses are the security firm’s own, from its report.

Severity	Open	Acknowledged	Fixed
Critical	0	0	3
High	0	1	1
Medium	0	0	0
Low	2	0	14

LowAdding Liquidity Will Also Charge TaxOpen

As there is no way for a user to be exempt from taxes, if a token pair is added via the `addDexAddress()` function, adding liquidity will also be subject to the 1% tax. In particular, this can cause issues when providing initial liquidity for the token as the tax must be taken into account when adding liquidity to the pair.

LowCalculation Can Be In `unchecked` BlockOpen

The amount is checked to be less than the balance of the user, with an upper bound of the `MAX_SUPPLY`. This means that the maximum value of `amount * 99` is `MAX_SUPPLY * 99` which is less than the maximum `uint256`. Thus this operation can never overflow and does not need to be checked. In addition, the `amountTransfer` is always less than or equal to the `amount`, so that `amount - amountTransfer` can never underflow.