Audit · firm’s term: audit report
QuillAudits reviewed YoloRekt on 7 Mar 2022: 38 findings, 0 critical; 23 marked fixed, 12 acknowledged, 3 open.
Report hosted on quillaudits.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 0 |
| High | 1 | 2 | 10 |
| Medium | 0 | 5 | 7 |
| Low | 2 | 5 | 6 |
Functions updateTracking and bumpDuringUpgrade are supposed to be called by NFTTracker and YoloNFTPack respectively. However, the modifier utilized i.e onlyAuthorized expands this capability to anyone having: • NFT_TRACKER or YOLO_NFT_PACK role in BiddersRewards • NFT_TRACKER or YOLO_NFT_PACK role in associated YoloRegistry of BiddersRewards • DEFAULT_ADMIN_ROLE or ADMIN_ROLE role in associated YoloRegistry of BiddersRewards can call the concerned functions. This widens up the attack surface, as authorized roles may take advantage of their privileged roles and may use these functions to exploit rewards.
Functions getCombinedLevelsWeighting and releaseFunds calculates weightage of every level as: rewardsMultiplier * (totalBidCount * COUNT_WEIGHT + totalCumulativeBidAmount * CUM_AMOUNT_WEIGHT) However, there is a strict condition, that rewardsMultiplier should be set for all the levels, and if any level’s rewardsMultiplier is not set, the entire function will revert. This can be optimized by making another memory array at the start, with a length same as nftLevelIdsListLength, and fetching and storing all the levels’ rewardsMultiplier. If any rewardsMultiplier is missing, the function can revert at this stage, without calculating the weightage of any level, thus reducing the number of operations and saving gas cost.
Functions getCombinedLevelsWeighting and releaseFunds calculates weightage of every level as: rewardsMultiplier * (totalBidCount * COUNT_WEIGHT + totalCumulativeBidAmount * CUM_AMOUNT_WEIGHT) However, the code can be optimized to calculate level weighting only if there exists any bid i.e., totalBidCount > 0, as it doesn’t make any sense to calculate level weighting if there exists no bid as the calculation will yield to 0 anyways.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (1)
449 projects reviewed · 593 reports · latest Nov 2026
See QuillAudits’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us