Edain-(Staking)

CertiK3 May 2022Files named in the report

Audit

CertiK reviewed Edain (Edain-(Staking)) on 3 May 2022: 10 findings, 0 critical; 6 marked fixed, 2 acknowledged, 2 open.

No open critical findings

Open the report Open Edain’s security record

Report hosted on skynet.certik.com.

Trustblock does not review code.

Findings10

Statuses are the security firm’s own, from its report.

Severity	Open	Acknowledged	Fixed
Critical	0	0	0
High	2	0	0
Medium	0	0	0
Low	0	2	6

LowReturn value not handledAcknowledged

The return value of the global function `.transfer` in `_unstake()` is not handled. This is an issue because `_addressToStakedAmount[_validatorNode]` is set to `0` before the `transfer` function is called. Therefore the amount will be set 0 regardless if the `transfer` succeeds.

LowUsage of `transfer()` for sending EtherAcknowledged

After [EIP-1884](https://eips.ethereum.org/EIPS/eip-1884) was included in the Istanbul hard fork, it is not recommended to use `.transfer()` or `.send()` for transferring ether as these functions have a hard-coded value for gas costs making them obsolete as they are forwarding a fixed amount of gas, specifically `2300`. This can cause issues in case the linked statements are meant to be able to transfer funds to other contracts instead of EOAs.